Bug 1972272

Summary:	[master] "baremetalhost.metal3.io/detached" uses boolean value where string is expected
Product:	OpenShift Container Platform	Reporter:	Mat Kowalski <mko>
Component:	assisted-installer	Assignee:	Mat Kowalski <mko>
assisted-installer sub component:	assisted-service	QA Contact:	Yuri Obshansky <yobshans>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	medium	CC:	aos-bugs, nshidlin
Version:	4.8	Keywords:	Triaged
Target Milestone:	---
Target Release:	4.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	AI-Team-Platform
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-10-18 17:34:18 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1972262

Description Mat Kowalski 2021-06-15 14:39:01 UTC

In the baremetal-operator the "baremetalhost.metal3.io/detached" annotation is a string value with the following behaviour

- existence of the label defines host as detached
- missing label defines the host as not detached

This has the following consequence - the value of the annotation is always ignored (this was a design decision).

In assisted-service we are setting value to "true" what may create an implicit assumption that the value is a boolean and setting it to "false" would reverse the behaviour. This is not the case and `baremetalhost.metal3.io/detached: "false"` still causes the host to be treated as detached.

The issue has been already fixed on master via https://github.com/openshift/assisted-service/pull/1974 so that we are setting `baremetalhost.metal3.io/detached: "assisted-service-controller"`

Comment 1 Mat Kowalski 2021-06-18 07:34:12 UTC

I have verified the bug after merging to master, QE confirmation/approval would be appreciated

```
# oc -n assisted-installer-manual-bundle describe bmh ostest-extraworker-0
Name:         ostest-extraworker-0                       
Namespace:    assisted-installer-manual-bundle            
Labels:       infraenvs.agent-install.openshift.io=myinfraenv
Annotations:  baremetalhost.metal3.io/detached: assisted-service-controller
              inspect.metal3.io: disabled
API Version:  metal3.io/v1alpha1
Kind:         BareMetalHost      
[...]
```

Comment 5 errata-xmlrpc 2021-10-18 17:34:18 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.9.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:3759