In the baremetal-operator the "baremetalhost.metal3.io/detached" annotation is a string value with the following behaviour - existence of the label defines host as detached - missing label defines the host as not detached This has the following consequence - the value of the annotation is always ignored (this was a design decision). In assisted-service we are setting value to "true" what may create an implicit assumption that the value is a boolean and setting it to "false" would reverse the behaviour. This is not the case and `baremetalhost.metal3.io/detached: "false"` still causes the host to be treated as detached. The issue has been already fixed on master via https://github.com/openshift/assisted-service/pull/1974 so that we are setting `baremetalhost.metal3.io/detached: "assisted-service-controller"`
this bug doesn't block OCP4.8.0 -release - the fix will be delivered the the ACM channel on the AI-operator add verified then
I have validated the fix. - hub cluster 4.8.0-fc.7 - acm ds snapshot 2.3.0-DOWNSTREAM-2021-07-06-05-34-53 Steps: - Deployed a SNO cluster using standard spoke cluster CRDs - Validated that "assisted-service-controller", rather than "true", is set in the bmh annotation of a deployed spoke cluster apiVersion: v1 items: - apiVersion: metal3.io/v1alpha1 kind: BareMetalHost metadata: annotations: baremetalhost.metal3.io/detached: assisted-service-controller inspect.metal3.io: disabled
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2021:2438