Bug 1973315

Summary:	[master] Updating ISO URL does not create a correct log entry
Product:	OpenShift Container Platform	Reporter:	Mat Kowalski <mko>
Component:	assisted-installer	Assignee:	Mat Kowalski <mko>
assisted-installer sub component:	assisted-service	QA Contact:	Yuri Obshansky <yobshans>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	low
Priority:	low	CC:	aos-bugs, bjacot, mfilanov, nmagnezi
Version:	4.8	Keywords:	Triaged
Target Milestone:	---
Target Release:	4.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	AI-Team-Hive KNI-EDGE-4.8
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:
Clones:	1974057 (view as bug list)		Environment:
Last Closed:	2021-10-18 17:35:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1974057

Description Mat Kowalski 2021-06-17 15:45:37 UTC

When, for any reason, InfraEnv gets a new ISO, the log in assisted-service contains new URL duplicated instead of showing both old and new one

```
time="2021-06-17T13:48:23Z" level=info msg="ISODownloadURL changed from https://assisted-service-assisted-installer-manual-bundle.apps.ostest.test.metalkube.org/api/assisted-install/v1/clusters/c74e6437-0695-4b20-898c-5ecdbcda6abd/downloads/image?api_key=eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9.eyJjbHVzdGVyX2lkIjoiYzc0ZTY0MzctMDY5NS00YjIwLTg5OGMtNWVjZGJjZGE2YWJkIn0.MrlJgAS6r4RwRtmO9sNGdw2asIB0lukADpGYPbNB8i8oS4sdSojyjCg52LZuz5S0wvQijGGazzkXZakNWBglLQ to https://assisted-service-assisted-installer-manual-bundle.apps.ostest.test.metalkube.org/api/assisted-install/v1/clusters/c74e6437-0695-4b20-898c-5ecdbcda6abd/downloads/image?api_key=eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9.eyJjbHVzdGVyX2lkIjoiYzc0ZTY0MzctMDY5NS00YjIwLTg5OGMtNWVjZGJjZGE2YWJkIn0.MrlJgAS6r4RwRtmO9sNGdw2asIB0lukADpGYPbNB8i8oS4sdSojyjCg52LZuz5S0wvQijGGazzkXZakNWBglLQ" func="github.com/openshift/assisted-service/internal/controller/controllers.(*InfraEnvReconciler).updateEnsureISOSuccess" file="/go/src/github.com/openshift/origin/internal/controller/con...
```

This creates a confusion as it's not possible to easily compare other CRs whether they contain old or new URL.

Comment 1 Nir Magnezi 2021-06-20 08:21:42 UTC

https://github.com/openshift/assisted-service/pull/1975 got merged.
Will backport in https://github.com/openshift/assisted-service/pull/2038 using Bug 1969363

Comment 2 Mat Kowalski 2021-07-02 09:12:48 UTC

https://github.com/openshift/assisted-service/pull/1975 fixed this BZ here as a side-effect, but it went under the radar because of no handling of multiple BZs in a single PR ...

Comment 3 Mat Kowalski 2021-07-02 09:14:31 UTC

Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1968542

Comment 6 errata-xmlrpc 2021-10-18 17:35:03 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.9.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:3759