Bug 1974057

Summary: [4.8.0] Updating ISO URL does not create a correct log entry
Product: Red Hat Advanced Cluster Management for Kubernetes Reporter: Michael Filanov <mfilanov>
Component: unspecifiedAssignee: Mat Kowalski <mko>
Status: CLOSED CURRENTRELEASE QA Contact: bjacot
Severity: low Docs Contact:
Priority: low    
Version: rhacm-2.3CC: aos-bugs, juhsu, mfilanov, mko, yfirst
Target Milestone: ---Keywords: Triaged
Target Release: rhacm-2.3.1Flags: ming: rhacm-2.3.z+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: AI-Team-Hive KNI-EDGE-4.8
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: 1973315 Environment:
Last Closed: 2021-09-20 21:34:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1973315    
Bug Blocks:    

Description Michael Filanov 2021-06-20 08:17:08 UTC 
+++ This bug was initially created as a clone of Bug #1973315 +++

When, for any reason, InfraEnv gets a new ISO, the log in assisted-service contains new URL duplicated instead of showing both old and new one

```
time="2021-06-17T13:48:23Z" level=info msg="ISODownloadURL changed from https://assisted-service-assisted-installer-manual-bundle.apps.ostest.test.metalkube.org/api/assisted-install/v1/clusters/c74e6437-0695-4b20-898c-5ecdbcda6abd/downloads/image?api_key=eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9.eyJjbHVzdGVyX2lkIjoiYzc0ZTY0MzctMDY5NS00YjIwLTg5OGMtNWVjZGJjZGE2YWJkIn0.MrlJgAS6r4RwRtmO9sNGdw2asIB0lukADpGYPbNB8i8oS4sdSojyjCg52LZuz5S0wvQijGGazzkXZakNWBglLQ to https://assisted-service-assisted-installer-manual-bundle.apps.ostest.test.metalkube.org/api/assisted-install/v1/clusters/c74e6437-0695-4b20-898c-5ecdbcda6abd/downloads/image?api_key=eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9.eyJjbHVzdGVyX2lkIjoiYzc0ZTY0MzctMDY5NS00YjIwLTg5OGMtNWVjZGJjZGE2YWJkIn0.MrlJgAS6r4RwRtmO9sNGdw2asIB0lukADpGYPbNB8i8oS4sdSojyjCg52LZuz5S0wvQijGGazzkXZakNWBglLQ" func="github.com/openshift/assisted-service/internal/controller/controllers.(*InfraEnvReconciler).updateEnsureISOSuccess" file="/go/src/github.com/openshift/origin/internal/controller/con...
```

This creates a confusion as it's not possible to easily compare other CRs whether they contain old or new URL.
Comment 1 Mat Kowalski 2021-07-02 09:13:40 UTC 
https://github.com/openshift/assisted-service/pull/2038 fixed this BZ here as a side-effect, but it went under the radar because of no handling of multiple BZs in a single PR ...
Comment 2 Mat Kowalski 2021-07-02 09:14:17 UTC 
Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1969363
Comment 12 ximhan 2021-08-20 07:26:57 UTC 
OpenShift engineering has decided to NOT ship 4.8.6 on 8/23 due to the following issue.
https://bugzilla.redhat.com/show_bug.cgi?id=1995785
All the fixes part will be now included in 4.8.7 on 8/30.
Comment 16 Mike Ng 2021-09-03 13:55:42 UTC 
G2Bsync 912084989 comment 
 CrystalChun Thu, 02 Sep 2021 21:53:38 UTC 
 G2Bsync Fix was picked up for ACM 2.3 GA
Included in this issue https://github.com/open-cluster-management/backlog/issues/13873