Bug 1976799

The documentation text flag should only be set after 'doc text' field is provided. Please provide the documentation text and set the flag to '?' again.

Bug 1869251 tracks deprecation of SSO. Without SSO there is no reason for ovirt-guest-agent and then it can be removed

Moving back to assigned and moving to doc team for documenting the removal.
The modified code is in virtio-win package.

If I understand correctly, I should remove this line in table 3.4 [1]:

--------
Table 3.4. Possible values for ADDLOCAL to install agents and required corresponding drivers

...

RHEV_Agent | Enables the Red Hat           | vioserial | FE_RHEV_Agent,FE_vioserial_driver 
             Virtualization Manager
             to receive internal virtual
             machine events and information,
             SSO support, Also enables the
             Manager to execute specific commands
             on a virtual machine.
...

--------


And we have a deprecation notice that I think could be clearer. Is this correct:


[NOTE]
====
Single Sign-On (SSO) is deprecated for virtual machines running Red Hat Enterprise Linux version 7 or earlier.
 
SSO is not supported for the following guest operating systems:
* Red Hat Enterprise Linux 8 or later 
* All versions of Windows 
====

This is actually confusing. "Deprecated" means: We don't provide support--use at your own risk.
So what is the case with support for RHEL 8 and Windows? Do they work but we don't support them? Or do they not work at all?




	
[1] https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/html-single/virtual_machine_management_guide#values_for_addlocal_to_customize_virtio_win_command_line_installation

[2] https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/html-single/virtual_machine_management_guide#Red_Hat_Virtualization_Guest_Agents_and_Drivers_windows_vm

(In reply to Steve Goodman from comment #4)
> If I understand correctly, I should remove this line in table 3.4 [1]:
> 
> --------
> Table 3.4. Possible values for ADDLOCAL to install agents and required
> corresponding drivers
> 
> ...
> 
> RHEV_Agent | Enables the Red Hat           | vioserial |
> FE_RHEV_Agent,FE_vioserial_driver 
>              Virtualization Manager
>              to receive internal virtual
>              machine events and information,
>              SSO support, Also enables the
>              Manager to execute specific commands
>              on a virtual machine.
> ...
> 
> --------
> 
> 
> And we have a deprecation notice that I think could be clearer. Is this
> correct:
> 
> 
> [NOTE]
> ====
> Single Sign-On (SSO) is deprecated for virtual machines running Red Hat
> Enterprise Linux version 7 or earlier.
>  
> SSO is not supported for the following guest operating systems:
> * Red Hat Enterprise Linux 8 or later 
> * All versions of Windows 
> ====
> 
> This is actually confusing. "Deprecated" means: We don't provide
> support--use at your own risk.
> So what is the case with support for RHEL 8 and Windows? Do they work but we
> don't support them? Or do they not work at all?
> 
> 
> 
> 
> 	
> [1]
> https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/
> html-single/
> virtual_machine_management_guide#values_for_addlocal_to_customize_virtio_win_
> command_line_installation
> 
> [2]
> https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/
> html-single/
> virtual_machine_management_guide#Red_Hat_Virtualization_Guest_Agents_and_Driv
> ers_windows_vm

You will need to remove:
1. From "Table 3.2. Red Hat Virtualization Guest agents and tools":
```
ovirt-guest-agent-common

Enables the Red Hat Virtualization Manager to receive internal virtual machine events and information such as IP address and installed applications. Also enables the Manager to execute specific commands on a virtual machine, such as shut down or reboot.

On virtual machines running Red Hat Enterprise Linux 6 or 7, ovirt-guest-agent-common installs tuned on your virtual machine and configures it to use an optimized, virtual machine profile. Use qemu-guest-agent on Red Hat Enterprise Linux 8 virtual machines

Server and Desktop.
```

and

```
rhev-sso

An agent that enables users to automatically log in to their virtual machines based on the credentials used to access the Red Hat Virtualization Manager.

Desktop.
```

2. From "3.3.2. Installing the guest agents, tools, and drivers on Windows":

```
Follow the prompts in the installation wizard. Ensure all check boxes in the list of components are selected, including the RHEV Agent, which is disabled by default.
```
to
```
Follow the prompts in the installation wizard.
```

```
After installation completes, the guest agents and drivers pass usage information to the Red Hat Virtualization Manager and enable you to access USB devices, single sign-on into virtual machines, and other functionality. The Red Hat Virtualization guest agent runs as a service called RHEV Agent that you can configure using the rhev-agent configuration file located in C:\Program Files\Virtio-Win\RHV_Agent.
````
to
```
After installation completes, the guest agents and drivers pass usage information to the Red Hat Virtualization Manager and enable you to access USB devices and other functionality.
```

3. From: Table 3.3. Possible values for ADDLOCAL to install drivers

Remove:
```
RHEV_Agent

Enables the Red Hat Virtualization Manager to receive internal virtual machine events and information, SSO support, Also enables the Manager to execute specific commands on a virtual machine.

vioserial

FE_RHEV_Agent,FE_vioserial_driver
```

(In reply to Steve Goodman from comment #4)
> If I understand correctly, I should remove this line in table 3.4 [1]:
> 
> --------
> Table 3.4. Possible values for ADDLOCAL to install agents and required
> corresponding drivers
> 
> ...
> 
> RHEV_Agent | Enables the Red Hat           | vioserial |
> FE_RHEV_Agent,FE_vioserial_driver 
>              Virtualization Manager
>              to receive internal virtual
>              machine events and information,
>              SSO support, Also enables the
>              Manager to execute specific commands
>              on a virtual machine.
> ...
> 
> --------
> 
> 
> And we have a deprecation notice that I think could be clearer. Is this
> correct:
> 
> 
> [NOTE]
> ====
> Single Sign-On (SSO) is deprecated for virtual machines running Red Hat
> Enterprise Linux version 7 or earlier.
>  
> SSO is not supported for the following guest operating systems:
> * Red Hat Enterprise Linux 8 or later 
> * All versions of Windows 
> ====
> 
> This is actually confusing. "Deprecated" means: We don't provide
> support--use at your own risk.
> So what is the case with support for RHEL 8 and Windows? Do they work but we
> don't support them? Or do they not work at all?
> 


> 
> 
> 
> 	
> [1]
> https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/
> html-single/
> virtual_machine_management_guide#values_for_addlocal_to_customize_virtio_win_
> command_line_installation
> 
> [2]
> https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/
> html-single/
> virtual_machine_management_guide#Red_Hat_Virtualization_Guest_Agents_and_Driv
> ers_windows_vm

They don't work at all because they don't exist :)

Hi QE,
I think that some of the things that are written have changed, specifically the installation from CLI.
Maybe QE can find the time to go over the instructions in this doc and make sure they still work? and if not then open a bug

(In reply to Gal Zaidman from comment #6)
 
> They don't work at all because they don't exist :)

So is this correct:

[NOTE]
====
Single Sign-On (SSO) is deprecated for virtual machines running Red Hat Enterprise Linux version 7 or earlier.
 
SSO functionality is not included for the following guest operating systems:
* Red Hat Enterprise Linux 8 or later 
* All versions of Windows
====

It's not clear to me from your latest comments if SSO is still supported for RHEL 7 and earlier virtual machines.

If SSO *is* supported for RHEL 7 and earlier VMs, then section 4.2. Configuring Single Sign-On for Virtual Machines [1] should be marked as applying only to RHEL 7 and earlier virtual machines, correct?

If SSO is *not* supported at all, then I need to remove section 4.2 entirely and update the deprecation notice to say that SSO has been removed entirely.

[1] https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/html-single/virtual_machine_management_guide/index#sect-Configuring_Single_Sign-On_for_Virtual_Machines

Please add comments directly in the merge request:

https://gitlab.cee.redhat.com/rhci-documentation/docs-Red_Hat_Enterprise_Virtualization/-/merge_requests/2080

(In reply to Steve Goodman from comment #8)
> (In reply to Gal Zaidman from comment #6)
>  
> > They don't work at all because they don't exist :)
> 
> So is this correct:
> 
> [NOTE]
> ====
> Single Sign-On (SSO) is deprecated for virtual machines running Red Hat
> Enterprise Linux version 7 or earlier.
>  
> SSO functionality is not included for the following guest operating systems:
> * Red Hat Enterprise Linux 8 or later 
> * All versions of Windows
> ====

don't know about rhel8, but the windows version is right

Let me remind you that this bug is for removing ovirt-guest-agent *windows* from *Virtio-win* installer - nothing about RHEL related, notice that there is a ovirt-guest-agent for linux and a different one for windows - this bug is about windows.

(In reply to Gal Zaidman from comment #12)
> Let me remind you that this bug is for removing ovirt-guest-agent *windows*
> from *Virtio-win* installer - nothing about RHEL related, notice that there
> is a ovirt-guest-agent for linux and a different one for windows - this bug
> is about windows.

I understand that, but some of this content, such as the deprecation notice, has info for both Linux and Windows, so I want to get it right for both of them. I asked the RHV Developers on gchat about RHEL VMs.

OK. As far as the Windows part is concerned, do you approve the MR?

(In reply to Steve Goodman from comment #14)
> OK. As far as the Windows part is concerned, do you approve the MR?

Can you link the PR? I don't see it on the bug

(In reply to Gal Zaidman from comment #15)
> > OK. As far as the Windows part is concerned, do you approve the MR?
> 
> Can you link the PR? I don't see it on the bug

https://gitlab.cee.redhat.com/rhci-documentation/docs-Red_Hat_Enterprise_Virtualization/-/merge_requests/2080

(In reply to Steve Goodman from comment #16)
> (In reply to Gal Zaidman from comment #15)
> > > OK. As far as the Windows part is concerned, do you approve the MR?
> > 
> > Can you link the PR? I don't see it on the bug
> 
> https://gitlab.cee.redhat.com/rhci-documentation/docs-
> Red_Hat_Enterprise_Virtualization/-/merge_requests/2080

There is only one thing to remove, on "6.14.5. Guest Agent Hooks" - remove the windows stuff
Other then that you are good to go

(In reply to Gal Zaidman from comment #17)
> There is only one thing to remove, on "6.14.5. Guest Agent Hooks" - remove
> the windows stuff
> Other then that you are good to go

Please take a final look and approve.

Gal approved offline.

Eli, please do peer review.

Please review the Github PR (In the Gitlab MR, only the deprecation notice in the Release Notes will be merged.)

https://github.com/oVirt/ovirt-site/pull/2593

(In reply to Gal Zaidman from comment #7)
> Hi QE,
> I think that some of the things that are written have changed, specifically
> the installation from CLI.
> Maybe QE can find the time to go over the instructions in this doc and make
> sure they still work? and if not then open a bug

Gal, can you specify which procedures you want QE to test?

Verified (ovirt-engine-4.4.9-0.6.el8ev)

procedure [1] is still working, using Wizard and CMD line commands.
no comments to add inside google doc [2]

This is published:

https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/html-single/virtual_machine_management_guide/index#Installing_the_Guest_Agents_and_Drivers_on_Windows

Gal,

We didn't remove this content, should we have?

https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/html-single/virtual_machine_management_guide/index#Configuring_Single_Sign_On_for_Windows_Virtual_Machines

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days