Bug 1977449

Summary: [master] Fix flaky test: invalid NMState config YAML
Product: OpenShift Container Platform Reporter: Nir Magnezi <nmagnezi>
Component: assisted-installerAssignee: Nir Magnezi <nmagnezi>
assisted-installer sub component: assisted-service QA Contact: Yuri Obshansky <yobshans>
Status: CLOSED ERRATA Docs Contact:
Severity: high    
Priority: unspecified CC: aos-bugs
Version: 4.9Keywords: Triaged
Target Milestone: ---   
Target Release: 4.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: AI-Team-Hive KNI-EDGE-4.8
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1977450 (view as bug list) Environment:
Last Closed: 2021-10-18 17:37:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1977450    

Description Nir Magnezi 2021-06-29 18:54:13 UTC
Description of problem:
=======================
Originally reported here https://issues.redhat.com/browse/MGMT-5324

We had inconsistent results, as shown here:
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_assisted-service/1456/pull-ci-openshift-assisted-service-master-subsystem-kubeapi-aws/1385056760468869120

The root cause is how InfraEnv used to requeue for errors, which changed with other fixes.
We will now requeue after 20s (as the backend limits image generation requests windows to be above 10s), and avoid requeue for non-recoverable issues such as BadRequest (invalid config).

Comment 5 errata-xmlrpc 2021-10-18 17:37:18 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.9.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:3759