Bug 1977450 - [4.8.0] Fix flaky test: invalid NMState config YAML
Summary: [4.8.0] Fix flaky test: invalid NMState config YAML
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Advanced Cluster Management for Kubernetes
Classification: Red Hat
Component: unspecified
Version: rhacm-2.3
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: rhacm-2.3.1
Assignee: Nir Magnezi
QA Contact: bjacot
URL:
Whiteboard: AI-Team-Hive KNI-EDGE-4.8
Depends On: 1977449
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-06-29 18:55 UTC by Nir Magnezi
Modified: 2021-09-21 17:28 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1977449
Environment:
Last Closed: 2021-09-21 17:28:14 UTC
Target Upstream Version:
Embargoed:
ming: rhacm-2.3.z+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github open-cluster-management backlog issues 15673 0 None None None 2021-08-27 15:58:11 UTC
Github openshift assisted-service pull 2136 0 None open [ocm-2.3] Bug 1977450: Fix flaky test: invalid NMState config YAML 2021-07-01 08:24:04 UTC

Description Nir Magnezi 2021-06-29 18:55:52 UTC
+++ This bug was initially created as a clone of Bug #1977449 +++

Description of problem:
=======================
Originally reported here https://issues.redhat.com/browse/MGMT-5324

We had inconsistent results, as shown here:
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_assisted-service/1456/pull-ci-openshift-assisted-service-master-subsystem-kubeapi-aws/1385056760468869120

The root cause is how InfraEnv used to requeue for errors, which changed with other fixes.
We will now requeue after 20s (as the backend limits image generation requests windows to be above 10s), and avoid requeue for non-recoverable issues such as BadRequest (invalid config).

Comment 11 ximhan 2021-08-20 07:26:57 UTC
OpenShift engineering has decided to NOT ship 4.8.6 on 8/23 due to the following issue.
https://bugzilla.redhat.com/show_bug.cgi?id=1995785
All the fixes part will be now included in 4.8.7 on 8/30.

Comment 15 Mike Ng 2021-09-03 13:52:07 UTC
G2Bsync 912080871 comment 
 CrystalChun Thu, 02 Sep 2021 21:46:07 UTC 
 G2Bsync
Fix was merged as part of ACM 2.3 GA
Picked up in https://github.com/open-cluster-management/backlog/issues/14081

Comment 17 juhsu 2021-09-20 21:17:47 UTC
Nir, can you verify this works since ACM 2.3.1 and 2.3.2 builds should have this fix.  Thanks.


Note You need to log in before you can comment on or make changes to this bug.