Bug 197868
| Summary: | clicking on email link brings up contacts | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthias Clasen <mclasen> | ||||||||||
| Component: | evolution | Assignee: | Matthew Barnes <mbarnes> | ||||||||||
| Status: | CLOSED RAWHIDE | QA Contact: | |||||||||||
| Severity: | medium | Docs Contact: | |||||||||||
| Priority: | medium | ||||||||||||
| Version: | rawhide | CC: | rstrode, stuart | ||||||||||
| Target Milestone: | --- | ||||||||||||
| Target Release: | --- | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | Linux | ||||||||||||
| Whiteboard: | |||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||
| Doc Text: | Story Points: | --- | |||||||||||
| Clone Of: | Environment: | ||||||||||||
| Last Closed: | 2006-08-17 02:28:12 UTC | Type: | --- | ||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||
| Documentation: | --- | CRM: | |||||||||||
| Verified Versions: | Category: | --- | |||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||
| Embargoed: | |||||||||||||
| Bug Depends On: | |||||||||||||
| Bug Blocks: | 197822 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Matthias Clasen
2006-07-06 19:52:08 UTC
So we need to do three things: 1) fix the gconf schema for the mailto uri handler to have --component=mail in it 2) fix evolution's "am i the default mailer" check to be able to handle --component=mail being in the command name 3) turn off the "am i the default mailer" check by default (another gconf schema change) *** Bug 190959 has been marked as a duplicate of this bug. *** (In reply to comment #1) Ray, can you point me to where #2 happens? (... man, in a different context that question could be really bad!) Matt, the check is done in plugins/default-mailer/default-mailer.c Created attachment 133881 [details]
Proposed patch for #2 of Ray's 3-easy-steps
This patch sets the /desktop/gnome/url-handlers/mailto/command GConf key to
evolution --component=mail %s
when a user tells Evolution to become the default mailer.
I also changed the logic that checks whether Evolution is the default mailer.
Where before it tried to match the entire mailer invocation command exactly,
now it just looks for the substring "evolution" at the beginning of the
command. This makes the check more robust so that an advanced user can
customize the way Evolution gets invoked without confusing Evolution's
default-mailer plugin.
(In reply to comment #1) Ray, what is the rationale for #3? we should evolution as the default already. If someone explicitly changed it, they know how to change it back. They don't need us to second guess their change. At least I think that was the rationale. don't really remember the meeting that well, though. Okay, that makes sense. In other words, it doesn't need to check if it's the default mailer every time it starts because we ship it as the default mailer. Created attachment 133985 [details]
Proposed patch for #1 of Ray's 3-easy-steps
This is for the gnome-vfs2 package.
Created attachment 133986 [details]
Proposed patch for #3 of Ray's 3-easy-steps
Created attachment 133995 [details]
More sophisticated patch for #2.
This version allows the mailto command to specify a path to the program.
e.g. /home/mbarnes/test/evolution-2.8 --component=mail %s
So with this logic, Evolution is the default mailer if the basename of the
first token in the command string starts with "evolution".
Sending these patches to Rawhide for a trial run. evolution-2.7.91-2 gnome-vfs2-2.15.91-2.fc6 This seems to be working in Rawhide so I'm going to close this bug, but the upstream bug remains open. I may re-open this one if upstream finds a problem with my proposed fix. |