Bug 1979315

Full build logs are here - 

https://copr.fedorainfracloud.org/coprs/nonamedotc/spyder5dev/builds/

Since pylsp requires pycodestyle, PR updating pyflakes, flake8 and pycodestyle have been submitted. 

Builds can be seen here - https://copr.fedorainfracloud.org/coprs/nonamedotc/spyder5dev/builds/

> A python implementation of language server protocol. This package provides
> the community maintained version of python-language-server.

That's very circular: if I don't already know what "python language server" is, this
tells me nothing. Is /bin/pylsp the main "entry point" for this package, i.e. are users
expected to call this directly? Or will this mostly be used as a library and/or backend
by other packages?

Also note that the %description has an empty leading line like in #1979275.

Updated SPEC URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-lsp-server/python-lsp-server.spec
Updated SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-lsp-server/python-lsp-server-1.1.0-2.fc34.src.rpm


Changes from previous spec are - 

- updated description
- use pypi_source macro
- avoid empty leading line in description
- remove egg cleanup


mock build is running here - https://copr.fedorainfracloud.org/coprs/nonamedotc/spyder5dev/build/2316171/


I disabled two tests that fail because I could not figure out how to fix it.

koji scratch build now that jsonrpc is built on rawhide - https://koji.fedoraproject.org/koji/taskinfo?taskID=71466427

> This package provides the community maintained version of python-language-server.

This is still unclear… Everything in Fedora is "community maintained". I assume that
there's some paid version? Please be more explicit.

Review:
+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ builds and installs OK
+ BR/R/P seem correct
+ %check is present and passes

rpmlint:
> python-lsp-server.src: E: description-line-too-long C This package provides the community maintained version of python-language-server.
Please wrap.

fedora-review doesn't find any issues.

Suggestion: add "Provides:pylsp".

Package is APPROVED.

How is the user supposed to launch this? Should it have a systemd user service file?

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-lsp-server

(In reply to Zbigniew Jędrzejewski-Szmek from comment #6)
> > This package provides the community maintained version of python-language-server.
> 
> This is still unclear… Everything in Fedora is "community maintained". I
> assume that
> there's some paid version? Please be more explicit.
> 

Yeah, I should have mentioned spyder-IDE team. I will add spyder-IDE team explicitly - not palantir or microsoft.

> Review:
> + package name is OK
> + license is acceptable for Fedora (MIT)
> + license is specified correctly
> + builds and installs OK
> + BR/R/P seem correct
> + %check is present and passes
> 
> rpmlint:
> > python-lsp-server.src: E: description-line-too-long C This package provides the community maintained version of python-language-server.
> Please wrap.
> 

Will do.

> fedora-review doesn't find any issues.
> 
> Suggestion: add "Provides:pylsp".
> 

I will do this in import.


> Package is APPROVED.

Thanks for the review.


(In reply to Zbigniew Jędrzejewski-Szmek from comment #7)
> How is the user supposed to launch this? Should it have a systemd user
> service file?


This package is consumed by editors (at the moment, only spyder). As far as I know, end user does not run this directly.

built on rawhide.