Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-lsp-black/python-lsp-black.spec SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-lsp-black/python-lsp-black-1.0.0-1.fc34.src.rpm Description: lsp-black is a python-lsp-server plugin that adds support to black autoformatter. This is forked from pyls-black to be compatible wth community maintained language-server (python-lsp-server). Fedora Account System Username: nonamedotc
Full build logs are here - https://copr.fedorainfracloud.org/coprs/nonamedotc/spyder5dev/builds/
Since pylsp requires pycodestyle, PR updating pyflakes, flake8 and pycodestyle have been submitted. Builds can be seen here - https://copr.fedorainfracloud.org/coprs/nonamedotc/spyder5dev/builds/
Updated SPEC URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-lsp-black/python-lsp-black.spec Updated SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-lsp-black/python-lsp-black-1.0.0-2.fc34.src.rpm
"wth community maintained" → "with community-maintained" > mkdir -p %{buildroot}%{_datadir}/licenses/python3-%{short_name}/license > install -m 644 %{SOURCE1} %{buildroot}%{_datadir}/licenses/python3-%{short_name} Why not just --- %prep cp %{SOURCE1} LICENSE %files %license LICENSE --- ? + package name is OK + license is acceptable for Fedora (MIT) + license is specified correctly + builds and installs OK + BR/R/P look OK + rpmlint finds nothing interesting + fedora-review finds nothing interesting Package is APPROVED. Suggestion: add Supplements:python-lsp-server.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-lsp-black
(In reply to Zbigniew Jędrzejewski-Szmek from comment #4) > "wth community maintained" → "with community-maintained" > I will make the same change as lsp-server and explicitly mention that this is maintained by spyder-IDE team. > > mkdir -p %{buildroot}%{_datadir}/licenses/python3-%{short_name}/license > > install -m 644 %{SOURCE1} %{buildroot}%{_datadir}/licenses/python3-%{short_name} > > Why not just > --- > %prep > cp %{SOURCE1} LICENSE > > %files > %license LICENSE > --- > ? > Fair enough. I will do this. > + package name is OK > + license is acceptable for Fedora (MIT) > + license is specified correctly > + builds and installs OK > + BR/R/P look OK > + rpmlint finds nothing interesting > + fedora-review finds nothing interesting > > Package is APPROVED. > Thanks for the review. > Suggestion: add Supplements:python-lsp-server. Will do.
This was built in rawhide, let's also close the ticket.