Bug 1979316

Summary:	Review Request: python-lsp-black - A python-lsp-server plugin that adds support to black autoformatter
Product:	[Fedora] Fedora	Reporter:	Mukundan Ragavan <nonamedotc>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	python-lsp-black-1.0.0-3.fc35	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-08-16 07:27:03 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1979315
Bug Blocks:

Description Mukundan Ragavan 2021-07-05 15:16:19 UTC

Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-lsp-black/python-lsp-black.spec
SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-lsp-black/python-lsp-black-1.0.0-1.fc34.src.rpm

Description:
lsp-black is a python-lsp-server plugin that adds support to black
autoformatter. This is forked from pyls-black to be compatible wth
community maintained language-server (python-lsp-server).

Fedora Account System Username: nonamedotc

Comment 1 Mukundan Ragavan 2021-07-05 15:17:13 UTC

Full build logs are here - 

https://copr.fedorainfracloud.org/coprs/nonamedotc/spyder5dev/builds/

Comment 2 Mukundan Ragavan 2021-07-05 16:01:22 UTC

Since pylsp requires pycodestyle, PR updating pyflakes, flake8 and pycodestyle have been submitted. 

Builds can be seen here - https://copr.fedorainfracloud.org/coprs/nonamedotc/spyder5dev/builds/

Comment 3 Mukundan Ragavan 2021-07-07 16:22:21 UTC

Updated SPEC URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-lsp-black/python-lsp-black.spec
Updated SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-lsp-black/python-lsp-black-1.0.0-2.fc34.src.rpm

Comment 4 Zbigniew Jędrzejewski-Szmek 2021-07-08 09:50:36 UTC

"wth community maintained" → "with community-maintained"

> mkdir -p %{buildroot}%{_datadir}/licenses/python3-%{short_name}/license
> install -m 644 %{SOURCE1} %{buildroot}%{_datadir}/licenses/python3-%{short_name}

Why not just
---
%prep
cp %{SOURCE1} LICENSE

%files
%license LICENSE
---
?

+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ builds and installs OK
+ BR/R/P look OK
+ rpmlint finds nothing interesting
+ fedora-review finds nothing interesting

Package is APPROVED.

Suggestion: add Supplements:python-lsp-server.

Comment 5 Gwyn Ciesla 2021-07-08 21:46:21 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-lsp-black

Comment 6 Mukundan Ragavan 2021-07-08 21:49:46 UTC

(In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
> "wth community maintained" → "with community-maintained"
> 

I will make the same change as lsp-server and explicitly mention that this is maintained by spyder-IDE team.


> > mkdir -p %{buildroot}%{_datadir}/licenses/python3-%{short_name}/license
> > install -m 644 %{SOURCE1} %{buildroot}%{_datadir}/licenses/python3-%{short_name}
> 
> Why not just
> ---
> %prep
> cp %{SOURCE1} LICENSE
> 
> %files
> %license LICENSE
> ---
> ?
> 

Fair enough. I will do this.

> + package name is OK
> + license is acceptable for Fedora (MIT)
> + license is specified correctly
> + builds and installs OK
> + BR/R/P look OK
> + rpmlint finds nothing interesting
> + fedora-review finds nothing interesting
> 
> Package is APPROVED.
> 

Thanks for the review.

> Suggestion: add Supplements:python-lsp-server.

Will do.

Comment 7 Zbigniew Jędrzejewski-Szmek 2021-08-16 07:27:03 UTC

This was built in rawhide, let's also close the ticket.