Bug 1980315
Summary: | Configure Grafana in hosted-engine setup by default | |||
---|---|---|---|---|
Product: | [oVirt] ovirt-engine-dwh | Reporter: | Aviv Litman <alitman> | |
Component: | Setup | Assignee: | Yedidyah Bar David <didi> | |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Pavel Novotny <pnovotny> | |
Severity: | high | Docs Contact: | ||
Priority: | high | |||
Version: | 4.4.7 | CC: | alitman, bugs, gdeolive, lsvaty, mperina, pnovotny, sradco | |
Target Milestone: | ovirt-4.4.10-2 | Keywords: | ZStream | |
Target Release: | 4.4.8 | Flags: | pm-rhel:
ovirt-4.4+
sbonazzo: devel_ack+ gdeolive: testing_ack+ |
|
Hardware: | Unspecified | |||
OS: | Unspecified | |||
Whiteboard: | ||||
Fixed In Version: | ovirt-engine-dwh-4.4.8 | Doc Type: | Enhancement | |
Doc Text: |
With previous versions, hosted-engine deployment didn't configure grafana, and so users had to manually configure it later, which was inconvenient.
With this version, hosted-engine deployment does configure grafana automatically by default.
doc team: Some more details and background:
1. I am writing doc text only for this bug, because that's enough IMO, although the actual needed changes are tracked also in other bugs - 1985927 and 1986393.
2. The current behavior (before fixing this bug) was introduced in 4.4.2, for bug 1866780. That one was about upgrade from 4.3 with dwh on a separate machine. To make the fix for current but not introduce that one, the change is slightly more complex: For new deployments, grafana is always configured (by default), but when restoring from backup (and also as part of upgrade from 4.3, which involves backup/restore), we configure grafana only if dwh was local to the engine machine.
So you might want to mention this in the doc text, if you want - something like "When using hosted-engine with --restore-from-file, grafana is configured only if dwh was configured locally, on the engine machine".
3. I now also filed a doc bug 1987193, for removing this from the documentation.
|
Story Points: | --- | |
Clone Of: | ||||
: | 1986393 (view as bug list) | Environment: | ||
Last Closed: | 2022-03-10 09:35:17 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | Integration | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | 1866780 | |||
Bug Blocks: | 1985927, 1986393 |
Description
Aviv Litman
2021-07-08 11:05:13 UTC
QE: Please test these flows: - Normal hosted-engine deployment (as you probably test automatically) - check that grafana is now configured and working (or at least, if checking automated testing results, that it created a grafana.log in the engine machine). - The flow of bug 1866780, to make sure we do not introduce regressions: 1. Deploy 4.3 hosted-engine 2. Migrate DWH and its database to a separate machine (can be a VM managed by that setup, or elsewhere), following the doc [1][2] 3. Upgrade to 4.4 using the doc [3] Make sure that it succeeds. grafana will not be configured, and can be configured on the dwh machine after it's upgraded to 4.4 as well, using 'engine-setup --reconfigure-optional-components'. [1] https://www.ovirt.org/documentation/data_warehouse_guide/#Migrating_Data_Warehouse_to_a_Separate_Machine_DWH_admin [2] https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.3/html/data_warehouse_guide/migrating_data_warehouse_to_a_separate_machine_dwh_admin [3] https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/html/upgrade_guide/she_upgrading_from_4-3 (In reply to Yedidyah Bar David from comment #1) > QE: Please test these flows: > > - Normal hosted-engine deployment (as you probably test automatically) - > check that grafana is now configured and working (or at least, if checking > automated testing results, that it created a grafana.log in the engine > machine). > > - The flow of bug 1866780, to make sure we do not introduce regressions: > > 1. Deploy 4.3 hosted-engine > 2. Migrate DWH and its database to a separate machine (can be a VM managed > by that setup, or elsewhere), following the doc [1][2] > 3. Upgrade to 4.4 using the doc [3] To clarify: The doc for upgrading a separate DWH machine is not complete yet, see bug 1874904. For now, until it's handled, consider the first part of bug 1874904 comment 5, "1. dwh + dwhdb on same separate machine.", as the reference. There, it says to manually run 'engine-setup' on the new DWH machine after 'engine-backup --mode=restore'. When you do this, engine-setup should ask you whether to configure grafana, should default to 'Yes', and this should work well. There is no need to run 'engine-setup' again with '--reconfigure-optional-components' after this. Verified in ovirt-engine-4.4.8.5-0.4.el8ev.noarch ovirt-engine-dwh-4.4.8-1.el8ev.noarch Grafana is installed & configured by default for new hosted engine deployments. Please verify also the flow of bug 1866780, to make sure we do not regress. See also comment 1. Thanks (In reply to Yedidyah Bar David from comment #6) > Please verify also the flow of bug 1866780, to make sure we do not regress. > See also comment 1. Thanks Moving back to ON_QA Moving to 4.4.9 as 4.4.8 was missed. Moving to 4.4.10 due to QE capacity. Verified in ovirt-engine-4.4.10.6-0.1.el8ev.noarch ovirt-engine-dwh-4.4.10-1.el8ev.noarch Verified flow: 1. install 4.3 hosted-engine 2. migrate DWH to separate machine 3. upgrade hosted-engine to 4.4, i.e., backup & reinstall & restore 4. upgrade remote DWH to 4.4, i.e., backup & reinstall & restore After DWH machine upgrade and restore, engine-setup asks if to install also Grafana (no need to run it with --reconfigure-optional-components). |