Bug 1980315 - Configure Grafana in hosted-engine setup by default
Summary: Configure Grafana in hosted-engine setup by default
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-dwh
Classification: oVirt
Component: Setup
Version: 4.4.7
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-4.4.10-2
: 4.4.8
Assignee: Yedidyah Bar David
QA Contact: Pavel Novotny
URL:
Whiteboard:
Depends On: 1866780
Blocks: 1985927 1986393
TreeView+ depends on / blocked
 
Reported: 2021-07-08 11:05 UTC by Aviv Litman
Modified: 2022-03-10 09:35 UTC (History)
7 users (show)

Fixed In Version: ovirt-engine-dwh-4.4.8
Doc Type: Enhancement
Doc Text:
With previous versions, hosted-engine deployment didn't configure grafana, and so users had to manually configure it later, which was inconvenient. With this version, hosted-engine deployment does configure grafana automatically by default. doc team: Some more details and background: 1. I am writing doc text only for this bug, because that's enough IMO, although the actual needed changes are tracked also in other bugs - 1985927 and 1986393. 2. The current behavior (before fixing this bug) was introduced in 4.4.2, for bug 1866780. That one was about upgrade from 4.3 with dwh on a separate machine. To make the fix for current but not introduce that one, the change is slightly more complex: For new deployments, grafana is always configured (by default), but when restoring from backup (and also as part of upgrade from 4.3, which involves backup/restore), we configure grafana only if dwh was local to the engine machine. So you might want to mention this in the doc text, if you want - something like "When using hosted-engine with --restore-from-file, grafana is configured only if dwh was configured locally, on the engine machine". 3. I now also filed a doc bug 1987193, for removing this from the documentation.
Clone Of:
: 1986393 (view as bug list)
Environment:
Last Closed: 2022-03-10 09:35:17 UTC
oVirt Team: Integration
Embargoed:
pm-rhel: ovirt-4.4+
sbonazzo: devel_ack+
gdeolive: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 115870 0 master MERGED packaging: setup: Usually default to configure grafana 2021-07-27 14:03:29 UTC

Internal Links: 1987193

Description Aviv Litman 2021-07-08 11:05:13 UTC 
Description of problem:
Hosted-engine setups (both new install and upgrade) not configuring Grafana as a result of bug: https://bugzilla.redhat.com/show_bug.cgi?id=1866780.

To get more users to use this important feature (Grafana), we want to change this behavior and configure Grafana in hosted-engine setup by default (both new install and upgrade).

Version-Release number of selected component (if applicable):
4.4.7

How reproducible:
100%

Steps to Reproduce:
1.install or upgrade hosted engine 
2.see that grafana is not installed by default

Actual results:
Hosted-engine setups (both new install and upgrade) will not configure grafana.

Expected results:
Hosted-engine setups (both new install and upgrade) will configure grafana.

Additional info:
Comment 1 Yedidyah Bar David 2021-07-29 08:05:36 UTC 
QE: Please test these flows:

- Normal hosted-engine deployment (as you probably test automatically) - check that grafana is now configured and working (or at least, if checking automated testing results, that it created a grafana.log in the engine machine).

- The flow of bug 1866780, to make sure we do not introduce regressions:

1. Deploy 4.3 hosted-engine
2. Migrate DWH and its database to a separate machine (can be a VM managed by that setup, or elsewhere), following the doc [1][2]
3. Upgrade to 4.4 using the doc [3]

Make sure that it succeeds. grafana will not be configured, and can be configured on the dwh machine after it's upgraded to 4.4 as well, using 'engine-setup --reconfigure-optional-components'.

[1] https://www.ovirt.org/documentation/data_warehouse_guide/#Migrating_Data_Warehouse_to_a_Separate_Machine_DWH_admin

[2] https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.3/html/data_warehouse_guide/migrating_data_warehouse_to_a_separate_machine_dwh_admin

[3] https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/html/upgrade_guide/she_upgrading_from_4-3
Comment 2 Yedidyah Bar David 2021-07-29 09:03:43 UTC 
(In reply to Yedidyah Bar David from comment #1)
> QE: Please test these flows:
> 
> - Normal hosted-engine deployment (as you probably test automatically) -
> check that grafana is now configured and working (or at least, if checking
> automated testing results, that it created a grafana.log in the engine
> machine).
> 
> - The flow of bug 1866780, to make sure we do not introduce regressions:
> 
> 1. Deploy 4.3 hosted-engine
> 2. Migrate DWH and its database to a separate machine (can be a VM managed
> by that setup, or elsewhere), following the doc [1][2]
> 3. Upgrade to 4.4 using the doc [3]

To clarify:

The doc for upgrading a separate DWH machine is not complete yet, see
bug 1874904. For now, until it's handled, consider the first part of
bug 1874904 comment 5, "1. dwh + dwhdb on same separate machine.", as
the reference.

There, it says to manually run 'engine-setup' on the new DWH machine
after 'engine-backup --mode=restore'. When you do this, engine-setup
should ask you whether to configure grafana, should default to 'Yes',
and this should work well. There is no need to run 'engine-setup'
again with '--reconfigure-optional-components' after this.
Comment 5 Pavel Novotny 2021-09-06 13:37:57 UTC 
Verified in
ovirt-engine-4.4.8.5-0.4.el8ev.noarch
ovirt-engine-dwh-4.4.8-1.el8ev.noarch

Grafana is installed & configured by default for new hosted engine deployments.
Comment 6 Yedidyah Bar David 2021-09-09 05:41:30 UTC 
Please verify also the flow of bug 1866780, to make sure we do not regress. See also comment 1. Thanks
Comment 7 Sandro Bonazzola 2021-09-24 09:29:26 UTC 
(In reply to Yedidyah Bar David from comment #6)
> Please verify also the flow of bug 1866780, to make sure we do not regress.
> See also comment 1. Thanks

Moving back to ON_QA
Comment 8 Lukas Svaty 2021-10-07 12:08:23 UTC 
Moving to 4.4.9 as 4.4.8 was missed.
Comment 9 Guilherme Santos 2021-11-08 07:15:25 UTC 
Moving to 4.4.10 due to QE capacity.
Comment 10 Pavel Novotny 2022-02-18 04:14:24 UTC 
Verified in
ovirt-engine-4.4.10.6-0.1.el8ev.noarch
ovirt-engine-dwh-4.4.10-1.el8ev.noarch

Verified flow:
1. install 4.3 hosted-engine
2. migrate DWH to separate machine
3. upgrade hosted-engine to 4.4, i.e., backup & reinstall & restore
4. upgrade remote DWH to 4.4, i.e., backup & reinstall & restore

After DWH machine upgrade and restore, engine-setup asks if to install also Grafana
(no need to run it with --reconfigure-optional-components).
Note You need to log in before you can comment on or make changes to this bug.