Bug 1980797

Summary: Rebase SBD on upstream 1.5.0 for RHEL 8.5
Product: Red Hat Enterprise Linux 8 Reporter: Klaus Wenninger <kwenning>
Component: sbdAssignee: Klaus Wenninger <kwenning>
Status: CLOSED ERRATA QA Contact: cluster-qe <cluster-qe>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.5CC: cfeist, cluster-maint, mmazoure, nhostako, ruth008johnson
Target Milestone: betaKeywords: Rebase, Triaged
Target Release: ---Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: sbd-1.5.0-2.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-11-09 18:50:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Klaus Wenninger 2021-07-09 14:43:59 UTC
In RHEL-8.5 we've already enabled startup/shutdown-syncing with pacemaker as default including the dependencies between pacemaker & sbd packages needed.

With sbd upstream-release 1.5.0 this default syncing was enabled as well.
That was adopted in Fedora-Rawhide sbd-1.5.0.
So for consistency it makes sense to sync the codebase with RHEL-8.5 as well.

Apart from the startup/shutdown-syncing default upstream sbd-1.5.0 brings mainly smaller bugfixes so that the risk and retest-effort should be minimal.

Comment 1 Klaus Wenninger 2021-07-09 15:19:49 UTC
Following is a list of fixes brought in with syncing with the Fedora Package

patches on top of 1.5.0: 

Fix: sbd-inquisitor: tolerate and strip any leading spaces of command line option values
Log: sbd-inquisitor: tell the actual watchdog device specified with `-w`
Build: Fix: correctly derrive package version from git
  fixes a regression brought in previously

Changes since 1.4.2:
    
- default to resource-syncing with pacemaker in spec-file and configure.ac
  This default has to match between sbd and pacemaker and
  thus qualifies this release for a minor-version-bump
- fix some regressions introduced by adding configurability previously
- adapt description of startup/shutdown sync with pacemaker
- make watchdog warning messages more understandable

Build: Fix: package version if release not labelled yet
Fix: sbd-inquisitor: prevent segfault if no command is supplied
Fix: sbd-inquisitor: take the defaults for the options set in sysconfig with empty strings
Log: sbd-inquisitor,sbd-md: make watchdog warning messages more understandable
Fix: sbd-inquisitor: calculate the default timeout for watchdog warning based on the watchdog timeout consistently
Fix: sbd-inquisitor: ensure the timeout for watchdog warning specified with `-5` option is respected
Fix: sbd-common: ensure the default timeout for watchdog warning is about 3/5 of the default watchdog timeout
Doc: adapt description of startup/shutdown sync with pacemaker
Fix: sbd-inquisitor: check SBD_SYNC_RESOURCE_STARTUP only in watch mode

Comment 7 Michal Mazourek 2021-08-30 11:32:29 UTC
Regression test suite was conducted, any potential issues will be reviewed and filed as new bzs.
Marking as VERIFIED for sbd-1.5.0-2.el8

Comment 9 errata-xmlrpc 2021-11-09 18:50:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (sbd bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4310

Comment 10 Ruth Johnson 2024-08-08 04:00:02 UTC
(In reply to Klaus Wenninger from comment #0)
> In RHEL-8.5 we've already enabled startup/shutdown-syncing with pacemaker as
> default including the dependencies between pacemaker & sbd packages needed.
> https://www.dollartree-compass.com
> With sbd upstream-release 1.5.0 this default syncing was enabled as well.
> That was adopted in Fedora-Rawhide sbd-1.5.0.
> So for consistency it makes sense to sync the codebase with RHEL-8.5 as well.
> 
> Apart from the startup/shutdown-syncing default upstream sbd-1.5.0 brings
> mainly smaller bugfixes so that the risk and retest-effort should be minimal.

You’re looking to align the codebase of RHEL-8.5 with the upstream release of sbd-1.5.0, which includes default startup/shutdown-syncing and some minor bug fixes. This should indeed help maintain consistency and minimize risk and retest efforts.

To proceed with syncing the codebase, you might want to:

Review the changes in sbd-1.5.0 to ensure all relevant updates are included.
Test the integration in a controlled environment to verify that the syncing and bug fixes work as expected.
Document any changes made during the syncing process for future reference and troubleshooting.