Bug 1981583
| Summary: | Review Request: rust-crc-catalog - Catalog of CRC algorithms | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rémi Lauzier <remilauzier> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review, remilauzier |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-12-13 19:37:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1965183 | ||
|
Description
Rémi Lauzier
2021-07-12 21:41:44 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/remilauzier/crc/fedora-rawhide-x86_64/03018972-rust-crc-catalog/rust-crc-catalog.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/remilauzier/crc/fedora-rawhide-x86_64/03018972-rust-crc-catalog/rust-crc-catalog-2.0.1-1.fc36.src.rpm Update to 2.0.1 Looks like when you regenerated the .spec file with rust2rpm, you didn't include the fixed %descriptions. Please fix that before importing the package. Other than that: === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add package to rust-sig with "commit" access - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre - track package in koschei for all built branches Not sure to understand what you want. The only modification I have made was to reduce the summary to make fedora happy. Should I not reduce it? I meant: With the last update (to 2.0.1) you also used rust2rpm 20 according to the first line of the .spec file, but the package %description values were not updated to the new ones with language / grammar fixes from rust2rpm 20.
You have:
This package contains library source intended for building other packages
which use "%{crate}" crate.
rust2rpm 20 would generate:
This package contains library source intended for building other packages which
use the "%{crate}" crate.
So please make this consistent before importing the package.
Thanks for the explanation! (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-crc-catalog FEDORA-2021-fc970a863a has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2021-fc970a863a FEDORA-2021-fc970a863a has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2021-ba15e3a787 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-ba15e3a787 FEDORA-2021-4266d0e2a3 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-4266d0e2a3 FEDORA-EPEL-2021-f1758a8d6f has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-f1758a8d6f FEDORA-2021-ba15e3a787 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-ba15e3a787 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-ba15e3a787 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-4266d0e2a3 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-4266d0e2a3 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-4266d0e2a3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2021-f1758a8d6f has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-f1758a8d6f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-4266d0e2a3 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2021-f1758a8d6f has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2021-ba15e3a787 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. |