Bug 1981583 - Review Request: rust-crc-catalog - Catalog of CRC algorithms
Summary: Review Request: rust-crc-catalog - Catalog of CRC algorithms
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1965183
TreeView+ depends on / blocked
 
Reported: 2021-07-12 21:41 UTC by Rémi Lauzier
Modified: 2021-12-22 02:06 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-12-13 19:37:59 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Comment 2 Fabio Valentini 2021-12-10 17:09:59 UTC
Looks like when you regenerated the .spec file with rust2rpm, you didn't include the fixed %descriptions.
Please fix that before importing the package. Other than that:

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add package to rust-sig with "commit" access

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre

- track package in koschei for all built branches

Comment 3 Rémi Lauzier 2021-12-10 18:44:53 UTC
Not sure to understand what you want. The only modification I have made was to reduce the summary to make fedora happy. Should I not reduce it?

Comment 4 Fabio Valentini 2021-12-10 20:54:57 UTC
I meant: With the last update (to 2.0.1) you also used rust2rpm 20 according to the first line of the .spec file, but the package %description values were not updated to the new ones with language / grammar fixes from rust2rpm 20.

You have:

This package contains library source intended for building other packages
which use "%{crate}" crate.

rust2rpm 20 would generate:

This package contains library source intended for building other packages which
use the "%{crate}" crate.

So please make this consistent before importing the package.

Comment 5 Rémi Lauzier 2021-12-10 20:59:50 UTC
Thanks for the explanation!

Comment 6 Gwyn Ciesla 2021-12-13 15:35:55 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-crc-catalog

Comment 7 Fedora Update System 2021-12-13 19:37:16 UTC
FEDORA-2021-fc970a863a has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2021-fc970a863a

Comment 8 Fedora Update System 2021-12-13 19:37:59 UTC
FEDORA-2021-fc970a863a has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2021-12-13 19:50:04 UTC
FEDORA-2021-ba15e3a787 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-ba15e3a787

Comment 10 Fedora Update System 2021-12-13 20:00:37 UTC
FEDORA-2021-4266d0e2a3 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-4266d0e2a3

Comment 11 Fedora Update System 2021-12-13 20:49:42 UTC
FEDORA-EPEL-2021-f1758a8d6f has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-f1758a8d6f

Comment 12 Fedora Update System 2021-12-14 01:08:39 UTC
FEDORA-2021-ba15e3a787 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-ba15e3a787 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-ba15e3a787

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2021-12-14 01:35:49 UTC
FEDORA-2021-4266d0e2a3 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-4266d0e2a3 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-4266d0e2a3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2021-12-14 01:46:43 UTC
FEDORA-EPEL-2021-f1758a8d6f has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-f1758a8d6f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2021-12-22 01:13:06 UTC
FEDORA-2021-4266d0e2a3 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2021-12-22 01:57:20 UTC
FEDORA-EPEL-2021-f1758a8d6f has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2021-12-22 02:06:24 UTC
FEDORA-2021-ba15e3a787 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.