Bug 1982143

Summary:	[RFE] volumeSnapshotStatuses reason does not check for volume type that do not support snapshots
Product:	Container Native Virtualization (CNV)	Reporter:	Yaacov Zamir <yzamir>
Component:	Storage	Assignee:	skagan
Status:	CLOSED ERRATA	QA Contact:	dalia <dafrank>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.9.0	CC:	alitke, cnv-qe-bugs, skagan, yadu
Target Milestone:	---
Target Release:	4.8.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	virt-operator-container-v4.8.2-5	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	2000204 (view as bug list)		Environment:
Last Closed:	2021-09-21 11:06:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2000204

Description Yaacov Zamir 2021-07-14 10:19:16 UTC

Description of problem:
In VirtualMachine status.volumeSnapshotStatuses[*].reason for some volumes types is wrong,
for example ConfigMap volumes don't need storage class, but the reason for it's none snapshot state is that it's lacking storage class.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. create a virtual machine with ephimeral, configMap (or other none snpashotable disk)
2. check VirtualMachine status.volumeSnapshotStatuses[*].reason
3.

Actual results:
"Volume type has no StorageClass defined"

Expected results:
"Snapshots are not supported for [containerDisk/CloudInit ...] volumes" (or a similar mreason)

Additional info:
list of volume types:
https://kubevirt.io/user-guide/virtual_machines/disks_and_volumes/#volumes

    cloudInitNoCloud       not?
    cloudInitConfigDrive   not?
    persistentVolumeClaim  snapshotable?
    dataVolume             snapshotable?
    ephemeral              not?
    containerDisk          not?
    emptyDisk              not?
    hostDisk               not?
    configMap              not?
    secret                 not?
    serviceAccount         not?
    downwardMetrics        not?

Comment 1 sgott 2021-07-14 12:06:28 UTC

Adam,

This BZ appears to be more storage related than virt. What do you think?

Comment 2 sgott 2021-07-15 13:41:24 UTC

Adam,

I've re-assigned this BZ to storage as it appears to fall under that umbrella. Please feel free to re-assign this if you feel this action was in error.

Comment 3 Adam Litke 2021-08-04 17:31:18 UTC

Won't make it in time for 4.8.1.  Pushing out.

Comment 4 Yan Du 2021-08-25 12:25:51 UTC

Hi, Shelly, do we have any update for the bug?

Comment 5 skagan 2021-08-25 12:40:41 UTC

yeah I just tried the new automation in my PR lets see if it will update the link

Comment 6 Adam Litke 2021-09-07 16:35:46 UTC

This should make 4.8.2 once the v4.8.2-15 build lands.

Comment 11 errata-xmlrpc 2021-09-21 11:06:44 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 4.8.2 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:3598