Bug 2000204 - [4.9.0] [RFE] volumeSnapshotStatuses reason does not check for volume type that do not support snapshots
Summary: [4.9.0] [RFE] volumeSnapshotStatuses reason does not check for volume type th...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: Storage
Version: 4.9.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 4.9.0
Assignee: skagan
QA Contact: dalia
URL:
Whiteboard:
Depends On: 1982143
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-09-01 14:59 UTC by Adam Litke
Modified: 2021-11-02 16:01 UTC (History)
7 users (show)

Fixed In Version: v4.9.0-193
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1982143
Environment:
Last Closed: 2021-11-02 16:01:09 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github kubevirt kubevirt pull 6319 0 None None None 2021-09-01 15:02:10 UTC
Red Hat Product Errata RHSA-2021:4104 0 None None None 2021-11-02 16:01:30 UTC

Description Adam Litke 2021-09-01 14:59:00 UTC
+++ This bug was initially created as a clone of Bug #1982143 +++

Description of problem:
In VirtualMachine status.volumeSnapshotStatuses[*].reason for some volumes types is wrong,
for example ConfigMap volumes don't need storage class, but the reason for it's none snapshot state is that it's lacking storage class.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. create a virtual machine with ephimeral, configMap (or other none snpashotable disk)
2. check VirtualMachine status.volumeSnapshotStatuses[*].reason
3.

Actual results:
"Volume type has no StorageClass defined"

Expected results:
"Snapshots are not supported for [containerDisk/CloudInit ...] volumes" (or a similar mreason)

Additional info:
list of volume types:
https://kubevirt.io/user-guide/virtual_machines/disks_and_volumes/#volumes

    cloudInitNoCloud       not?
    cloudInitConfigDrive   not?
    persistentVolumeClaim  snapshotable?
    dataVolume             snapshotable?
    ephemeral              not?
    containerDisk          not?
    emptyDisk              not?
    hostDisk               not?
    configMap              not?
    secret                 not?
    serviceAccount         not?
    downwardMetrics        not?

--- Additional comment from  on 2021-07-14 12:06:28 UTC ---

Adam,

This BZ appears to be more storage related than virt. What do you think?

--- Additional comment from  on 2021-07-15 13:41:24 UTC ---

Adam,

I've re-assigned this BZ to storage as it appears to fall under that umbrella. Please feel free to re-assign this if you feel this action was in error.

--- Additional comment from Adam Litke on 2021-08-04 17:31:18 UTC ---

Won't make it in time for 4.8.1.  Pushing out.

--- Additional comment from Yan Du on 2021-08-25 12:25:51 UTC ---

Hi, Shelly, do we have any update for the bug?

--- Additional comment from  on 2021-08-25 12:40:41 UTC ---

yeah I just tried the new automation in my PR lets see if it will update the link

Comment 1 dalia 2021-10-03 11:50:25 UTC
verified on CNV 4.9.0

1. create a vm with none snpashotable disk 
2. check VirtualMachine status.volumeSnapshotStatuses[*].reason:

  Volume Snapshot Statuses:
    Enabled:  false
    Name:     containerdisk
    Reason:   Snapshot is not supported for this volumeSource type [containerdisk]

Comment 4 errata-xmlrpc 2021-11-02 16:01:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 4.9.0 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:4104


Note You need to log in before you can comment on or make changes to this bug.