Bug 1982500
| Summary: | Review Request: rust-temp_testdir - Little crate to use temp directory in crate | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, eclipseo, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-08-09 15:31:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Davide Cavalca
2021-07-15 03:49:31 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=71919953 - Please ask upstream to add a license file in their crate - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Checks pass - Conforms to Packaging Guidelines Package approved Hold your horses. - Please ask upstream to add a license file in their crate Since neither the crate nor the upstream git repository contain a license file, this is not acceptable for a Fedora package with MIT and ASL 2.0 licenses. Please work with upstream to include license files *first*. (In reply to Fabio Valentini from comment #3) > Hold your horses. > > - Please ask upstream to add a license file in their crate > > Since neither the crate nor the upstream git repository contain a license > file, this is not acceptable for a Fedora package with MIT and ASL 2.0 > licenses. > Please work with upstream to include license files *first*. The crates and Cargo.toml state license = "MIT/Apache-2.0" Yes, but that's only mildly less bad. Both Apache-2.0 and MIT licenses *require* that redistributed sources include a copy of the license text. Filed https://github.com/la10736/temp_testdir/pull/5 to add the missing license files. Spec URL: https://dcavalca.fedorapeople.org/review/rust-temp_testdir/rust-temp_testdir.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-temp_testdir/rust-temp_testdir-0.2.3-1.fc37.src.rpm Changelog: - re-run rust2rpm - add missing license files Thanks, looks good now. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT or ASL 2.0) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches Thanks! $ fedpkg request-repo rust-temp_testdir 1982500 https://pagure.io/releng/fedora-scm-requests/issue/46107 $ fedpkg request-branch --all-releases --repo rust-temp_testdir https://pagure.io/releng/fedora-scm-requests/issue/46108 https://pagure.io/releng/fedora-scm-requests/issue/46109 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-temp_testdir FEDORA-2022-a0556a4d6b has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a0556a4d6b FEDORA-2022-a0556a4d6b has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-59af3b4d2c has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-59af3b4d2c FEDORA-2022-50efc24619 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-50efc24619 FEDORA-2022-59af3b4d2c has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-59af3b4d2c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-59af3b4d2c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-50efc24619 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-50efc24619 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-50efc24619 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-59af3b4d2c has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-50efc24619 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. |