Bug 1982500 - Review Request: rust-temp_testdir - Little crate to use temp directory in crate
Summary: Review Request: rust-temp_testdir - Little crate to use temp directory in crate
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-07-15 03:49 UTC by Davide Cavalca
Modified: 2022-08-12 01:41 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-08-09 15:31:48 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github la10736 temp_testdir pull 5 0 None open Add missing license files 2022-02-13 05:14:19 UTC

Description Davide Cavalca 2021-07-15 03:49:31 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-temp_testdir/rust-temp_testdir.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-temp_testdir/rust-temp_testdir-0.2.3-1.fc35.src.rpm

Description:
Little crate to use temp directory in crate. You can chose if delete it after
use or not to debugging purpose.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2021-07-15 03:49:33 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=71919953

Comment 2 Robert-André Mauchin 🐧 2022-01-23 17:25:49 UTC
 - Please ask upstream to add a license file in their crate


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Checks pass
 - Conforms to Packaging Guidelines

Package approved

Comment 3 Fabio Valentini 2022-01-23 17:48:00 UTC
Hold your horses.

- Please ask upstream to add a license file in their crate

Since neither the crate nor the upstream git repository contain a license file, this is not acceptable for a Fedora package with MIT and ASL 2.0 licenses.
Please work with upstream to include license files *first*.

Comment 4 Robert-André Mauchin 🐧 2022-01-23 18:03:11 UTC
(In reply to Fabio Valentini from comment #3)
> Hold your horses.
> 
> - Please ask upstream to add a license file in their crate
> 
> Since neither the crate nor the upstream git repository contain a license
> file, this is not acceptable for a Fedora package with MIT and ASL 2.0
> licenses.
> Please work with upstream to include license files *first*.

The crates and Cargo.toml state license = "MIT/Apache-2.0"

Comment 5 Fabio Valentini 2022-01-23 18:06:03 UTC
Yes, but that's only mildly less bad.

Both Apache-2.0 and MIT licenses *require* that redistributed sources include a copy of the license text.

Comment 6 Davide Cavalca 2022-02-13 05:13:55 UTC
Filed https://github.com/la10736/temp_testdir/pull/5 to add the missing license files.

Comment 8 Fabio Valentini 2022-07-29 09:39:45 UTC
Thanks, looks good now.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT or ASL 2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 9 Davide Cavalca 2022-08-01 16:11:31 UTC
Thanks!

$ fedpkg request-repo rust-temp_testdir 1982500
https://pagure.io/releng/fedora-scm-requests/issue/46107
$ fedpkg request-branch --all-releases --repo rust-temp_testdir
https://pagure.io/releng/fedora-scm-requests/issue/46108
https://pagure.io/releng/fedora-scm-requests/issue/46109

Comment 10 Gwyn Ciesla 2022-08-01 17:04:30 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-temp_testdir

Comment 11 Fedora Update System 2022-08-09 15:23:04 UTC
FEDORA-2022-a0556a4d6b has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a0556a4d6b

Comment 12 Fedora Update System 2022-08-09 15:31:48 UTC
FEDORA-2022-a0556a4d6b has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2022-08-09 15:54:00 UTC
FEDORA-2022-59af3b4d2c has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-59af3b4d2c

Comment 14 Fedora Update System 2022-08-09 16:03:24 UTC
FEDORA-2022-50efc24619 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-50efc24619

Comment 15 Fedora Update System 2022-08-10 01:38:47 UTC
FEDORA-2022-59af3b4d2c has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-59af3b4d2c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-59af3b4d2c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2022-08-10 02:10:14 UTC
FEDORA-2022-50efc24619 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-50efc24619 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-50efc24619

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2022-08-12 01:38:13 UTC
FEDORA-2022-59af3b4d2c has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2022-08-12 01:41:58 UTC
FEDORA-2022-50efc24619 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.