Bug 1982624

Summary:	Review Request: php-giggsey-locale - Locale functions required by libphonenumber-for-php
Product:	[Fedora] Fedora	Reporter:	Christopher Engelhard <ce>
Component:	Package Review	Assignee:	Tomas Korbar <tkorbar>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora, package-review, tkorbar
Target Milestone:	---	Flags:	tkorbar: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-08-02 16:19:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1982621

Description Christopher Engelhard 2021-07-15 10:17:33 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-rawhide-x86_64/02329598-php-giggsey-locale/php-giggsey-locale.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-rawhide-x86_64/02329598-php-giggsey-locale/php-giggsey-locale-1.9-1.fc35.src.rpm

Description: A library providing up to date CLDR. Primarily as a requirement of libphonenumber-for-php.

Since this package is set up to use rpmautospec, rpmlint/fedora-review will complain about missing dist tags & macros in changelog. These are spurious errors/warnings.
If you run phpcompatinfo for testing, you'll need to increase the default php memory limit.
This package is available from the lcts/nextcloud Copr, so you can also test it using 'fedora-review --copr-build 2329598'


Fedora Account System Username: lcts

Comment 1 Tomas Korbar 2021-07-21 07:36:59 UTC

Hi,
To be honest, this package looks ok to me already. I did not
find any violation of packaging guidelines, thus giving
review +.

Comment 2 Remi Collet 2021-07-21 08:37:19 UTC

Not running upstream test suite is indeed only recommended, not mandatory

But the effort worth it (and is quite simple)

IMHO, Unbundling without CI doesn't make sense

Comment 3 Christopher Engelhard 2021-07-24 18:28:37 UTC

Thanks Tomas!

I'll be adding the tests to all these packages by getting the sources via git checkout.

Comment 4 Gwyn Ciesla 2021-07-25 18:02:40 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/php-giggsey-locale