Spec URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-rawhide-x86_64/02329598-php-giggsey-locale/php-giggsey-locale.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-rawhide-x86_64/02329598-php-giggsey-locale/php-giggsey-locale-1.9-1.fc35.src.rpm Description: A library providing up to date CLDR. Primarily as a requirement of libphonenumber-for-php. Since this package is set up to use rpmautospec, rpmlint/fedora-review will complain about missing dist tags & macros in changelog. These are spurious errors/warnings. If you run phpcompatinfo for testing, you'll need to increase the default php memory limit. This package is available from the lcts/nextcloud Copr, so you can also test it using 'fedora-review --copr-build 2329598' Fedora Account System Username: lcts
Hi, To be honest, this package looks ok to me already. I did not find any violation of packaging guidelines, thus giving review +.
Not running upstream test suite is indeed only recommended, not mandatory But the effort worth it (and is quite simple) IMHO, Unbundling without CI doesn't make sense
Thanks Tomas! I'll be adding the tests to all these packages by getting the sources via git checkout.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/php-giggsey-locale