Bug 1982647

Summary:	Review Request: php-thecodingmachine-safe - PHP core functions that throw exceptions instead of returning FALSE on error
Product:	[Fedora] Fedora	Reporter:	Christopher Engelhard <ce>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora, otto.liljalaakso, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-09-18 00:45:25 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449, 1982652

Description Christopher Engelhard 2021-07-15 10:47:49 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-rawhide-x86_64/02329614-php-thecodingmachine-safe/php-thecodingmachine-safe.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-rawhide-x86_64/02329614-php-thecodingmachine-safe/php-thecodingmachine-safe-1.3.3-1.fc35.src.rpm

Description: A set of core PHP functions rewritten to throw exceptions instead of returning false when an error is encountered. The project is deprecated upstream in favour of the PHP8 version of it, but still in use by many PHP7-based projects.

Since this package is set up to use rpmautospec, rpmlint/fedora-review will complain about missing dist tags & macros in changelog. These are spurious errors/warnings.

This package is available from the lcts/nextcloud Copr, so you can also test it using 'fedora-review --copr-build 2329614'

Fedora Account System Username: lcts

Comment 1 Otto Liljalaakso 2021-08-16 11:13:49 UTC

Reviewed, findings below:

1.
> This project is deprecated.

Where does this statement come from?
I cannot find any upstream reference.

2.
> Autoloader: %{_datadir}/php/%{ns_dir}/autoload.php

Format differently to look less like a specfile tag.

3. 
> : Remove leftover VCS files
> rm %{buildroot}%{_datadir}/php/%{ns_dir}/generated/Exceptions/.gitkeep

It would be good to submit a pull request to remove the file also from upstream.

4.
The folder structure is somewhat strange,
with namespace being /usr/share/php/Safe
and having folders lib/, deprecated/ and generated/ under it.
I would have expected to see TheCodingMachine as the namespace.
However, given that this project extends the standard library,
perhaps doing it like that makes sense.
So I will just note this here,
I do not think any action is required here.

Comment 2 Package Review 2022-09-17 15:01:02 UTC

Package was never imported.
The ticket status is being reset, since creating the repository will require a fresh approval.
Let us know if you're still interested in this package.

Comment 3 Package Review 2022-09-18 00:45:25 UTC

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.