Spec URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-rawhide-x86_64/02329614-php-thecodingmachine-safe/php-thecodingmachine-safe.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-rawhide-x86_64/02329614-php-thecodingmachine-safe/php-thecodingmachine-safe-1.3.3-1.fc35.src.rpm Description: A set of core PHP functions rewritten to throw exceptions instead of returning false when an error is encountered. The project is deprecated upstream in favour of the PHP8 version of it, but still in use by many PHP7-based projects. Since this package is set up to use rpmautospec, rpmlint/fedora-review will complain about missing dist tags & macros in changelog. These are spurious errors/warnings. This package is available from the lcts/nextcloud Copr, so you can also test it using 'fedora-review --copr-build 2329614' Fedora Account System Username: lcts
Reviewed, findings below: 1. > This project is deprecated. Where does this statement come from? I cannot find any upstream reference. 2. > Autoloader: %{_datadir}/php/%{ns_dir}/autoload.php Format differently to look less like a specfile tag. 3. > : Remove leftover VCS files > rm %{buildroot}%{_datadir}/php/%{ns_dir}/generated/Exceptions/.gitkeep It would be good to submit a pull request to remove the file also from upstream. 4. The folder structure is somewhat strange, with namespace being /usr/share/php/Safe and having folders lib/, deprecated/ and generated/ under it. I would have expected to see TheCodingMachine as the namespace. However, given that this project extends the standard library, perhaps doing it like that makes sense. So I will just note this here, I do not think any action is required here.
Package was never imported. The ticket status is being reset, since creating the repository will require a fresh approval. Let us know if you're still interested in this package.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.