Bug 1983884
| Summary: | Review Request: rust-local_ipaddress - Get your local IP address without panic | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-07-11 01:52:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Davide Cavalca
2021-07-20 05:17:17 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=72224787 - Please patch the README.md to use correct end of line encoding local_ipaddress.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/local_ipaddress/README.md for file in README.md; do sed "s|\r||g" $file > $file.new && \ touch -r $file $file.new && \ mv $file.new $file done - License ok - Latest version packaged - Build in Mock - No rpmlint errors - Checks pass - Conforms to Packaging Guidelines Package approved Please regenerate the .spec file with rust2rpm 20 before building this package for Fedora. This package produces a binary: %{_bindir}/local_ipaddress
You need to either change the package to not build this binary if it is not needed, or add the appropriate license breakdown and License field to the subpackage that contains the binary.
Thanks, will address comments and fix the license on import. $ fedpkg request-repo rust-local_ipaddress 1983884 https://pagure.io/releng/fedora-scm-requests/issue/42150 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-local_ipaddress This package has been reviewed and created over a month ago. Please don't forget to import and build it, too. This crate has no dependencies, so the effective license is still MIT even with the binary. FEDORA-2022-28049a086e has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-28049a086e FEDORA-2022-28049a086e has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-817ec0b59b has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-817ec0b59b FEDORA-2022-1c5ddbe52e has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-1c5ddbe52e FEDORA-2022-817ec0b59b has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-817ec0b59b` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-817ec0b59b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-1c5ddbe52e has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-1c5ddbe52e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-1c5ddbe52e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-817ec0b59b has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-1c5ddbe52e has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. |