Bug 1983884 - Review Request: rust-local_ipaddress - Get your local IP address without panic
Summary: Review Request: rust-local_ipaddress - Get your local IP address without panic
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-07-20 05:17 UTC by Davide Cavalca
Modified: 2022-07-20 01:38 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-07-11 01:52:43 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2021-07-20 05:17:17 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-local_ipaddress/rust-local_ipaddress.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-local_ipaddress/rust-local_ipaddress-0.1.3-1.fc35.src.rpm

Description:
Get your local IP address without panic.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2021-07-20 05:17:19 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=72224787

Comment 2 Robert-André Mauchin 🐧 2022-01-23 20:45:32 UTC
 - Please patch the README.md to use correct end of line encoding

local_ipaddress.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/local_ipaddress/README.md

for file in README.md; do
 sed "s|\r||g" $file > $file.new && \
 touch -r $file $file.new && \
 mv $file.new $file
done

 - License ok
 - Latest version packaged
 - Build in Mock
 - No rpmlint errors
 - Checks pass
 - Conforms to Packaging Guidelines

Package approved

Please regenerate the .spec file with rust2rpm 20 before building this package for Fedora.

Comment 3 Fabio Valentini 2022-01-23 22:39:54 UTC
This package produces a binary: %{_bindir}/local_ipaddress

You need to either change the package to not build this binary if it is not needed, or add the appropriate license breakdown and License field to the subpackage that contains the binary.

Comment 4 Davide Cavalca 2022-02-13 05:00:55 UTC
Thanks, will address comments and fix the license on import.

$ fedpkg request-repo rust-local_ipaddress 1983884
https://pagure.io/releng/fedora-scm-requests/issue/42150

Comment 5 Igor Raits 2022-02-13 10:45:20 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-local_ipaddress

Comment 6 Fabio Valentini 2022-03-19 12:20:43 UTC
This package has been reviewed and created over a month ago. Please don't forget to import and build it, too.

Comment 7 Davide Cavalca 2022-07-11 01:14:56 UTC
This crate has no dependencies, so the effective license is still MIT even with the binary.

Comment 8 Fedora Update System 2022-07-11 01:50:59 UTC
FEDORA-2022-28049a086e has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-28049a086e

Comment 9 Fedora Update System 2022-07-11 01:52:43 UTC
FEDORA-2022-28049a086e has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2022-07-11 15:25:43 UTC
FEDORA-2022-817ec0b59b has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-817ec0b59b

Comment 11 Fedora Update System 2022-07-11 15:34:07 UTC
FEDORA-2022-1c5ddbe52e has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-1c5ddbe52e

Comment 12 Fedora Update System 2022-07-12 02:31:20 UTC
FEDORA-2022-817ec0b59b has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-817ec0b59b`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-817ec0b59b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-07-12 02:38:13 UTC
FEDORA-2022-1c5ddbe52e has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-1c5ddbe52e \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-1c5ddbe52e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-07-20 01:31:12 UTC
FEDORA-2022-817ec0b59b has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2022-07-20 01:38:30 UTC
FEDORA-2022-1c5ddbe52e has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.