Bug 1984114 (rust-trash)

Summary:	Review Request: rust-trash - Library for moving files and folders to the Recycle Bin
Product:	[Fedora] Fedora	Reporter:	Igor Raits <igor.raits>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, package-review, remilauzier
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-11-28 13:28:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1956138, 1991267

Description Igor Raits 2021-07-20 17:37:42 UTC

Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-trash.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-trash-2.0.1-1.fc35.src.rpm
Description:
Library for moving files and folders to the Recycle Bin.
Fedora Account System Username: ignatenkobrain

Comment 1 Fabio Valentini 2021-07-30 10:23:51 UTC

Package generated with rust2rpm, which simplifies the review.

- package builds and installs without errors on rawhide
- latest version is packaged
- license (MIT) is correct and acceptable for Fedora
- license file is shipped with %license
- consistent with Rust Packaging Guidelines
- tests disabled with good, documented reason

Package APPROVED.

Two additional reminders:

- add a small comment why you're patching out dependencies
  (i.e. "drop windows-specific dependencies" or something like that)
- don't forget to request f34 branch and build the package there too,
  otherwise I can't update dua-cli and other stuff there

Comment 2 Fabio Valentini 2021-07-30 10:24:34 UTC

(Would be great if you could review https://bugzilla.redhat.com/show_bug.cgi?id=1987098 for me in return.)

Comment 3 Fabio Valentini 2021-08-10 21:03:20 UTC

*** Bug 1991292 has been marked as a duplicate of this bug. ***