Bug 1984114 (rust-trash) - Review Request: rust-trash - Library for moving files and folders to the Recycle Bin
Summary: Review Request: rust-trash - Library for moving files and folders to the Recy...
Keywords:
Status: CLOSED RAWHIDE
Alias: rust-trash
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1991292 (view as bug list)
Depends On:
Blocks: 1956138 1991267
TreeView+ depends on / blocked
 
Reported: 2021-07-20 17:37 UTC by Igor Raits
Modified: 2021-11-28 13:28 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-11-28 13:28:39 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+

Attachments (Terms of Use)

Description Igor Raits 2021-07-20 17:37:42 UTC 
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-trash.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-trash-2.0.1-1.fc35.src.rpm
Description:
Library for moving files and folders to the Recycle Bin.
Fedora Account System Username: ignatenkobrain
Comment 1 Fabio Valentini 2021-07-30 10:23:51 UTC 
Package generated with rust2rpm, which simplifies the review.

- package builds and installs without errors on rawhide
- latest version is packaged
- license (MIT) is correct and acceptable for Fedora
- license file is shipped with %license
- consistent with Rust Packaging Guidelines
- tests disabled with good, documented reason

Package APPROVED.

Two additional reminders:

- add a small comment why you're patching out dependencies
  (i.e. "drop windows-specific dependencies" or something like that)
- don't forget to request f34 branch and build the package there too,
  otherwise I can't update dua-cli and other stuff there
Comment 2 Fabio Valentini 2021-07-30 10:24:34 UTC 
(Would be great if you could review https://bugzilla.redhat.com/show_bug.cgi?id=1987098 for me in return.)
Comment 3 Fabio Valentini 2021-08-10 21:03:20 UTC 
*** Bug 1991292 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.