Bug 1984196
| Summary: | Review Request: rust-vtparse - Low level escape sequence parser | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, michel, package-review |
| Target Milestone: | --- | Flags: | michel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-01-28 14:49:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1984198 | ||
|
Description
Davide Cavalca
2021-07-20 23:07:50 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=72268426 Approved with a note - consider upgrading to 0.6.0 unless it breaks termwiz === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - X - latest version of the crate is packaged -- please update to 0.6.0 unless termwiz can't use it - license matches upstream specification (MIT) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add package to rust-sig with "commit" access - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches Thanks! $ fedpkg request-repo rust-vtparse 1984196 https://pagure.io/releng/fedora-scm-requests/issue/40978 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-vtparse FEDORA-2022-8576b3a039 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8576b3a039 FEDORA-2022-8576b3a039 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. > - license files are included with %license in %files
This is not true, there is no LICENSE file. This package should not have been approved in this state.
Please notify upstream that their published crates don't contain LICENSE files (and are hence in violation of the MIT license).
If that is not possible within a short timeframe, you'll need to include the LICENSE.md file from the root of the upstream repo on GitHub manually.
Filed an upstream issue here: https://github.com/wez/wezterm/issues/2347 |