Bug 1984196 - Review Request: rust-vtparse - Low level escape sequence parser
Summary: Review Request: rust-vtparse - Low level escape sequence parser
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1984198
TreeView+ depends on / blocked
 
Reported: 2021-07-20 23:07 UTC by Davide Cavalca
Modified: 2023-08-22 20:13 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-01-28 14:49:20 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2021-07-20 23:07:50 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-vtparse/rust-vtparse.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-vtparse/rust-vtparse-0.5.0-1.fc35.src.rpm

Description:
Low level escape sequence parser.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2021-07-20 23:07:52 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=72268426

Comment 2 Michel Lind 2022-01-15 04:37:50 UTC
Approved with a note - consider upgrading to 0.6.0 unless it breaks termwiz

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- X - latest version of the crate is packaged -- please update to 0.6.0 unless termwiz can't use it
- license matches upstream specification (MIT) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add package to rust-sig with "commit" access

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 3 Davide Cavalca 2022-01-15 04:51:58 UTC
Thanks!

$ fedpkg request-repo rust-vtparse 1984196
https://pagure.io/releng/fedora-scm-requests/issue/40978

Comment 4 Jens Petersen 2022-01-16 06:05:42 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-vtparse

Comment 5 Fedora Update System 2022-01-28 14:46:25 UTC
FEDORA-2022-8576b3a039 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8576b3a039

Comment 6 Fedora Update System 2022-01-28 14:49:20 UTC
FEDORA-2022-8576b3a039 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fabio Valentini 2022-05-25 14:43:57 UTC
> - license files are included with %license in %files

This is not true, there is no LICENSE file. This package should not have been approved in this state.
Please notify upstream that their published crates don't contain LICENSE files (and are hence in violation of the MIT license).
If that is not possible within a short timeframe, you'll need to include the LICENSE.md file from the root of the upstream repo on GitHub manually.

Comment 8 Fabio Valentini 2022-08-02 13:31:21 UTC
Filed an upstream issue here:
https://github.com/wez/wezterm/issues/2347


Note You need to log in before you can comment on or make changes to this bug.