Bug 1984210

Summary:	Review Request: build-constraints-rpm-macros - RPM macros for build constraints
Product:	[Fedora] Fedora	Reporter:	Michel Lind <michel>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-07-03 07:43:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1982748

Description Michel Lind 2021-07-21 00:43:50 UTC

Spec URL: https://salimma.fedorapeople.org/specs/admin/build-constraints-rpm-macros.spec
SRPM URL: https://salimma.fedorapeople.org/specs/admin/build-constraints-rpm-macros-1-1.fc34.src.rpm
Description: 
This package contains macros to constraint resource use during the build
process.

Fedora Account System Username: salimma

Comment 1 Neal Gompa 2021-07-21 00:48:21 UTC

Taking this review.

Comment 2 Neal Gompa 2021-07-21 00:49:51 UTC

Review notes:

- Packaging follows naming guidelines
- Package licensing is indicated correctly
- Packaging builds and installs
- No serious issues from rpmlint

PACKAGE APPROVED.

Comment 3 Michel Lind 2021-07-21 00:53:20 UTC

so this is basically a bit simplified from the Suse definitions in https://build.opensuse.org/package/view_file/openSUSE:Factory/memory-constraints/memory-constraints.macros?expand=1, which was in turn based on the Ceph definition in https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/ceph.spec

- removed the cruft for disabling parallelism; this makes sense for Ceph but does not make sense in the Suse macro, since the setting to control it was automatically computed instead of user-specified
  - any spec can disable parallelism as usual, by overriding `_smp_build_ncpus`
- like Ceph, but unlike the Suse definition, use physical memory and not physical+swap. We don't want swap thrashing during a build
- override _smp_build_ncpus instead of _smp_mflags (which is just -j%{_smp_build_ncpus} anyway)

Thanks Neal!

Comment 4 Michel Lind 2021-07-21 00:55:44 UTC

$ fedpkg request-repo build-constraints-rpm-macros 1984210                                          
https://pagure.io/releng/fedora-scm-requests/issue/35830

Comment 5 Gwyn Ciesla 2021-07-21 14:17:03 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/build-constraints-rpm-macros

Comment 6 Package Review 2022-07-03 07:43:36 UTC

Package is now in repositories, closing review.