Spec URL: https://salimma.fedorapeople.org/specs/admin/build-constraints-rpm-macros.spec SRPM URL: https://salimma.fedorapeople.org/specs/admin/build-constraints-rpm-macros-1-1.fc34.src.rpm Description: This package contains macros to constraint resource use during the build process. Fedora Account System Username: salimma
Taking this review.
Review notes: - Packaging follows naming guidelines - Package licensing is indicated correctly - Packaging builds and installs - No serious issues from rpmlint PACKAGE APPROVED.
so this is basically a bit simplified from the Suse definitions in https://build.opensuse.org/package/view_file/openSUSE:Factory/memory-constraints/memory-constraints.macros?expand=1, which was in turn based on the Ceph definition in https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/ceph.spec - removed the cruft for disabling parallelism; this makes sense for Ceph but does not make sense in the Suse macro, since the setting to control it was automatically computed instead of user-specified - any spec can disable parallelism as usual, by overriding `_smp_build_ncpus` - like Ceph, but unlike the Suse definition, use physical memory and not physical+swap. We don't want swap thrashing during a build - override _smp_build_ncpus instead of _smp_mflags (which is just -j%{_smp_build_ncpus} anyway) Thanks Neal!
$ fedpkg request-repo build-constraints-rpm-macros 1984210 https://pagure.io/releng/fedora-scm-requests/issue/35830
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/build-constraints-rpm-macros
Package is now in repositories, closing review.