Bug 1985571

Summary: storage - covscan error - DEADCODE - vdopool if create_vdo else parent
Product: Red Hat Enterprise Linux 9 Reporter: Rich Megginson <rmeggins>
Component: rhel-system-rolesAssignee: Rich Megginson <rmeggins>
Status: CLOSED CURRENTRELEASE QA Contact: Jakub Haruda <jharuda>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 9.0CC: djez, jharuda, nhosoi, pkettman, spetrosi, yizhan
Target Milestone: betaKeywords: Triaged
Target Release: 9.0 Beta   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: role:storage
Fixed In Version: rhel-system-roles-1.7.2-1.el9 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 1985572 (view as bug list) Environment:
Last Closed: 2021-12-07 22:04:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1985572    

Description Rich Megginson 2021-07-24 00:12:16 UTC 
Description of problem:

There are two covscan reports in storage code:

 8. auto-maintenance-ec364d2e0bd422b69f34871a1188114f368097a0/storage/library/blivet.py:701: dead_error_line: Execution cannot reach the sub-expression "vdopool" inside this expression: "create_vdo ? vdopool : parent".
#   699|                   # This is here for backwards compatibility. Until 8.4 blivet does not support
#   700|                   # vdo_lv optional parameter
#   701|->                 device = self._blivet.new_lv(name=self._volume['name'],
#   702|                                                parents=[vdopool if create_vdo else parent],
#   703|                                                size=size, fmt=fmt)


and

 11. auto-maintenance-ec364d2e0bd422b69f34871a1188114f368097a0/storage/library/blivet.py:695: dead_error_line: Execution cannot reach the sub-expression "parent" inside this expression: "create_vdo ? vdopool : parent".
#   693|           try:
#   694|               if create_vdo:
#   695|->                 device = self._blivet.new_lv(name=self._volume['name'], vdo_lv=create_vdo,
#   696|                                                parents=[vdopool if create_vdo else parent],
#   697|                                                size=size, fmt=fmt)


the one on 695 should just be [vdopool] and the other one should just be [parent]

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info: