RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1985572 - storage - covscan error - DEADCODE - vdopool if create_vdo else parent
Summary: storage - covscan error - DEADCODE - vdopool if create_vdo else parent
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: rhel-system-roles
Version: 8.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: beta
: 8.5
Assignee: Rich Megginson
QA Contact: Zhang Yi
URL:
Whiteboard: role:storage
Depends On: 1985571
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-07-24 00:16 UTC by Rich Megginson
Modified: 2021-11-09 20:38 UTC (History)
6 users (show)

Fixed In Version: rhel-system-roles-1.6.4-1.el8
Doc Type: No Doc Update
Doc Text:
Clone Of: 1985571
Environment:
Last Closed: 2021-11-09 17:46:02 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github linux-system-roles storage pull 217 0 None closed omit unnecessary conditional - deadcode reported by static scanner 2021-07-29 21:18:52 UTC
Red Hat Product Errata RHBA-2021:4159 0 None None None 2021-11-09 17:46:15 UTC

Description Rich Megginson 2021-07-24 00:16:53 UTC 
+++ This bug was initially created as a clone of Bug #1985571 +++

Description of problem:

There are two covscan reports in storage code:

 8. auto-maintenance-ec364d2e0bd422b69f34871a1188114f368097a0/storage/library/blivet.py:701: dead_error_line: Execution cannot reach the sub-expression "vdopool" inside this expression: "create_vdo ? vdopool : parent".
#   699|                   # This is here for backwards compatibility. Until 8.4 blivet does not support
#   700|                   # vdo_lv optional parameter
#   701|->                 device = self._blivet.new_lv(name=self._volume['name'],
#   702|                                                parents=[vdopool if create_vdo else parent],
#   703|                                                size=size, fmt=fmt)


and

 11. auto-maintenance-ec364d2e0bd422b69f34871a1188114f368097a0/storage/library/blivet.py:695: dead_error_line: Execution cannot reach the sub-expression "parent" inside this expression: "create_vdo ? vdopool : parent".
#   693|           try:
#   694|               if create_vdo:
#   695|->                 device = self._blivet.new_lv(name=self._volume['name'], vdo_lv=create_vdo,
#   696|                                                parents=[vdopool if create_vdo else parent],
#   697|                                                size=size, fmt=fmt)


the one on 695 should just be [vdopool] and the other one should just be [parent]

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 10 errata-xmlrpc 2021-11-09 17:46:02 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (rhel-system-roles bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4159
Note You need to log in before you can comment on or make changes to this bug.