Bug 1990713
| Summary: | Review Request: rust-lino - Command line text editor with notepad like key bindings | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-10-31 19:01:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Davide Cavalca
2021-08-06 04:11:59 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=73369119 Are you still interested in packaging this crate? If yes, please refresh the packaging with rust2rpm 21. Spec URL: https://dcavalca.fedorapeople.org/review/rust-lino/rust-lino.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-lino/rust-lino-0.10.0-1.fc38.src.rpm Changelog: - re-run rust2rpm - update to 0.10.0 Looks good to me, just the License tag for the binary subpackage is missing. You can use the commands / macros that are proposed here: https://pagure.io/fedora-rust/rust2rpm/pull-request/217 For now, you can shell into the mock chroot after a successful build, and run this command in the crate's source root to generate a license summary: cargo tree --workspace --offline --edges no-build,no-dev,no-proc-macro --no-dedupe --target all --prefix none --format "# {l}" | sed -e "s: / :/:g" -e "s:/: OR :g" | sort -u Or, to generate the complete license information for all statically linked dependencies: cargo tree --workspace --offline --edges no-build,no-dev,no-proc-macro --no-dedupe --target all --prefix none --format "{l}: {p}" | sed -e "s: ($(pwd))::g" -e "s: / :/:g" -e "s:/: OR :g" | sort -u Spec URL: https://dcavalca.fedorapeople.org/review/rust-lino/rust-lino.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-lino/rust-lino-0.10.0-1.fc38.src.rpm Changelog: - update license for binary subpackage Sorry for the delay! Thanks for the update, package looks good to me. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license breakdown and summary for statically linked binary is included - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches Thanks! $ fedpkg request-repo rust-lino 1990713 https://pagure.io/releng/fedora-scm-requests/issue/48524 $ fedpkg request-branch --repo rust-lino f37 https://pagure.io/releng/fedora-scm-requests/issue/48525 $ fedpkg request-branch --repo rust-lino f36 https://pagure.io/releng/fedora-scm-requests/issue/48526 $ fedpkg request-branch --repo rust-lino f35 https://pagure.io/releng/fedora-scm-requests/issue/48527 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-lino FEDORA-2022-03a8d5cd5b has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-03a8d5cd5b FEDORA-2022-03a8d5cd5b has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-5b86a23ebc has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-5b86a23ebc FEDORA-2022-797b3e0792 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-797b3e0792 FEDORA-2022-5b86a23ebc has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-5b86a23ebc \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-5b86a23ebc See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-797b3e0792 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-797b3e0792 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-797b3e0792 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-797b3e0792 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-5b86a23ebc has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. |