Bug 1990713 - Review Request: rust-lino - Command line text editor with notepad like key bindings
Summary: Review Request: rust-lino - Command line text editor with notepad like key bi...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-08-06 04:11 UTC by Davide Cavalca
Modified: 2022-11-10 22:29 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-10-31 19:01:41 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2021-08-06 04:11:59 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-lino/rust-lino.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-lino/rust-lino-0.9.2-1.fc35.src.rpm

Description:
Command line text editor with notepad like key bindings.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2021-08-06 04:12:01 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=73369119

Comment 2 Fabio Valentini 2022-04-30 09:44:46 UTC
Are you still interested in packaging this crate?
If yes, please refresh the packaging with rust2rpm 21.

Comment 3 Davide Cavalca 2022-10-19 04:33:30 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-lino/rust-lino.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-lino/rust-lino-0.10.0-1.fc38.src.rpm

Changelog:
- re-run rust2rpm
- update to 0.10.0

Comment 4 Fabio Valentini 2022-10-19 09:06:18 UTC
Looks good to me, just the License tag for the binary subpackage is missing.

You can use the commands / macros that are proposed here:
https://pagure.io/fedora-rust/rust2rpm/pull-request/217

For now, you can shell into the mock chroot after a successful build, and run this command in the crate's source root to generate a license summary:

cargo tree --workspace --offline --edges no-build,no-dev,no-proc-macro --no-dedupe --target all --prefix none --format "# {l}" | sed -e "s: / :/:g" -e "s:/: OR :g" | sort -u

Or, to generate the complete license information for all statically linked dependencies:

cargo tree --workspace --offline --edges no-build,no-dev,no-proc-macro --no-dedupe --target all --prefix none --format "{l}: {p}" | sed -e "s: ($(pwd))::g" -e "s: / :/:g" -e "s:/: OR :g" | sort -u

Comment 5 Davide Cavalca 2022-10-26 03:08:22 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-lino/rust-lino.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-lino/rust-lino-0.10.0-1.fc38.src.rpm

Changelog:
- update license for binary subpackage

Comment 6 Fabio Valentini 2022-10-31 13:52:22 UTC
Sorry for the delay! Thanks for the update, package looks good to me.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license breakdown and summary for statically linked binary is included
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 7 Davide Cavalca 2022-10-31 17:45:44 UTC
Thanks!

$ fedpkg request-repo rust-lino 1990713
https://pagure.io/releng/fedora-scm-requests/issue/48524
$ fedpkg request-branch --repo rust-lino f37
https://pagure.io/releng/fedora-scm-requests/issue/48525
$ fedpkg request-branch --repo rust-lino f36
https://pagure.io/releng/fedora-scm-requests/issue/48526
$ fedpkg request-branch --repo rust-lino f35
https://pagure.io/releng/fedora-scm-requests/issue/48527

Comment 8 Gwyn Ciesla 2022-10-31 18:30:59 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-lino

Comment 9 Fedora Update System 2022-10-31 19:00:23 UTC
FEDORA-2022-03a8d5cd5b has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-03a8d5cd5b

Comment 10 Fedora Update System 2022-10-31 19:01:41 UTC
FEDORA-2022-03a8d5cd5b has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2022-10-31 19:15:44 UTC
FEDORA-2022-5b86a23ebc has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-5b86a23ebc

Comment 12 Fedora Update System 2022-10-31 20:45:44 UTC
FEDORA-2022-797b3e0792 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-797b3e0792

Comment 13 Fedora Update System 2022-11-01 14:47:36 UTC
FEDORA-2022-5b86a23ebc has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-5b86a23ebc \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-5b86a23ebc

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-11-01 16:05:40 UTC
FEDORA-2022-797b3e0792 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-797b3e0792 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-797b3e0792

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2022-11-09 11:20:39 UTC
FEDORA-2022-797b3e0792 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2022-11-10 22:29:17 UTC
FEDORA-2022-5b86a23ebc has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.