Bug 1990925

Summary:	Review Request: rust-quantiles - Collection of approximate quantile algorithms
Product:	[Fedora] Fedora	Reporter:	Davide Cavalca <davide>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rust-quantiles-0.7.1-1.fc36	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-09-03 15:05:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1990927

Description Davide Cavalca 2021-08-06 15:20:14 UTC

Spec URL: https://dcavalca.fedorapeople.org/review/rust-quantiles/rust-quantiles.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-quantiles/rust-quantiles-0.7.1-1.fc35.src.rpm

Description:
Collection of approximate quantile algorithms.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2021-08-06 15:20:16 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=73391686

Comment 2 Fabio Valentini 2021-08-26 10:01:21 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is disabled with valid reasoning
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Two minor issues:

1) "resources/afl_crashes_20161215.txt" probably doesn't need to be marked as %doc, right?

The file looks like american-fuzzy-lop fuzzer output or something like that? It's not even valid ASCII / UTF-8.

2) If the tests don't compile with quickcheck 1.0, then don't patch the version at all, just do "%bcond_with check" and add a comment that the quickcheck dev-dependency is outdated (maybe poke upstream about fixing that?)

Please fix those two before importing the package.

Other than that, package APPROVED.

Comment 3 Davide Cavalca 2021-08-26 15:13:57 UTC

I had tried fixing the tests to work with the new quickcheck properly but failed miserably. I'll put together a repro for upstream and file an issue there.

$ fedpkg request-repo rust-quantiles 1990925
https://pagure.io/releng/fedora-scm-requests/issue/36556

Comment 4 Gwyn Ciesla 2021-08-26 15:17:25 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-quantiles