Spec URL: https://dcavalca.fedorapeople.org/review/rust-quantiles/rust-quantiles.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-quantiles/rust-quantiles-0.7.1-1.fc35.src.rpm Description: Collection of approximate quantile algorithms. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=73391686
Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is disabled with valid reasoning - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Two minor issues: 1) "resources/afl_crashes_20161215.txt" probably doesn't need to be marked as %doc, right? The file looks like american-fuzzy-lop fuzzer output or something like that? It's not even valid ASCII / UTF-8. 2) If the tests don't compile with quickcheck 1.0, then don't patch the version at all, just do "%bcond_with check" and add a comment that the quickcheck dev-dependency is outdated (maybe poke upstream about fixing that?) Please fix those two before importing the package. Other than that, package APPROVED.
I had tried fixing the tests to work with the new quickcheck properly but failed miserably. I'll put together a repro for upstream and file an issue there. $ fedpkg request-repo rust-quantiles 1990925 https://pagure.io/releng/fedora-scm-requests/issue/36556
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-quantiles