Bug 1991149
| Summary: | Review Request: rust-sinit - Simple init system for use in containers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-08-19 17:29:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Davide Cavalca
2021-08-07 16:26:33 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=73454201 Are you still interested in packaging this crate? If yes, please refresh the packaging with rust2rpm 21. Effective license calculation: (MIT OR Apache-2.0) and (MIT or ASL 2.0) = MIT or ASL 2.0 Full list: # MIT OR Apache-2.0: rust-libc 0.2.127 # MIT or ASL 2.0: rust-getopts 0.2.21 # MIT or ASL 2.0: rust-unicode-width 0.1.9 Spec URL: https://dcavalca.fedorapeople.org/review/rust-sinit/rust-sinit.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-sinit/rust-sinit-0.1.2-1.fc38.src.rpm Changelog: - re-run rust2rpm - add effective license to binary subpackage > Effective license calculation: (MIT OR Apache-2.0) and (MIT or ASL 2.0) = MIT or ASL 2.0 > > Full list: > # MIT OR Apache-2.0: rust-libc 0.2.127 > # MIT or ASL 2.0: rust-getopts 0.2.21 > # MIT or ASL 2.0: rust-unicode-width 0.1.9 I'm pretty sure you missed that sinit itself is BSD-2-Clause here :) Ahah, good catch, thanks! Spec URL: https://dcavalca.fedorapeople.org/review/rust-sinit/rust-sinit.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-sinit/rust-sinit-0.1.2-1.fc38.src.rpm Changelog: - update effective license for binary subpackage Thanks, looks good to me now. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass (there are no tests) - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license for binary sub-package is correctly specified - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches === Nit-pick: Upstream might want to exclude the "sigtest.go" file from published crate sources, it seems like source code for an unused test binary. Thanks! $ fedpkg request-repo rust-sinit 1991149 https://pagure.io/releng/fedora-scm-requests/issue/46517 $ fedpkg request-branch --repo rust-sinit f37 https://pagure.io/releng/fedora-scm-requests/issue/46518 $ fedpkg request-branch --repo rust-sinit f36 https://pagure.io/releng/fedora-scm-requests/issue/46519 $ fedpkg request-branch --repo rust-sinit f35 https://pagure.io/releng/fedora-scm-requests/issue/46520 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sinit FEDORA-2022-a6b50670be has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a6b50670be FEDORA-2022-9717d7b577 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9717d7b577 FEDORA-2022-a6b50670be has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-9717d7b577 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-c6605f7660 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-c6605f7660 FEDORA-2022-e163f1739d has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-e163f1739d FEDORA-2022-c6605f7660 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-c6605f7660 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-c6605f7660 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-e163f1739d has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-e163f1739d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-e163f1739d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-c6605f7660 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-e163f1739d has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. |