Bug 1991149 - Review Request: rust-sinit - Simple init system for use in containers
Summary: Review Request: rust-sinit - Simple init system for use in containers
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-08-07 16:26 UTC by Davide Cavalca
Modified: 2022-08-27 20:52 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-08-19 17:29:50 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2021-08-07 16:26:33 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-sinit/rust-sinit.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-sinit/rust-sinit-0.1.2-1.fc35.src.rpm

Description:
Simple init system for use in containers.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2021-08-07 16:26:34 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=73454201

Comment 2 Fabio Valentini 2022-04-30 09:45:07 UTC
Are you still interested in packaging this crate?
If yes, please refresh the packaging with rust2rpm 21.

Comment 3 Davide Cavalca 2022-08-14 15:26:32 UTC
Effective license calculation: (MIT OR Apache-2.0) and (MIT or ASL 2.0) = MIT or ASL 2.0

Full list:
# MIT OR Apache-2.0: rust-libc 0.2.127
# MIT or ASL 2.0: rust-getopts 0.2.21
# MIT or ASL 2.0: rust-unicode-width 0.1.9

Comment 4 Davide Cavalca 2022-08-14 15:28:20 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-sinit/rust-sinit.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-sinit/rust-sinit-0.1.2-1.fc38.src.rpm

Changelog:
- re-run rust2rpm
- add effective license to binary subpackage

Comment 5 Fabio Valentini 2022-08-17 09:37:45 UTC
> Effective license calculation: (MIT OR Apache-2.0) and (MIT or ASL 2.0) = MIT or ASL 2.0
>
> Full list:
> # MIT OR Apache-2.0: rust-libc 0.2.127
> # MIT or ASL 2.0: rust-getopts 0.2.21
> # MIT or ASL 2.0: rust-unicode-width 0.1.9

I'm pretty sure you missed that sinit itself is BSD-2-Clause here :)

Comment 6 Davide Cavalca 2022-08-17 14:22:55 UTC
Ahah, good catch, thanks!

Spec URL: https://dcavalca.fedorapeople.org/review/rust-sinit/rust-sinit.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-sinit/rust-sinit-0.1.2-1.fc38.src.rpm

Changelog:
- update effective license for binary subpackage

Comment 7 Fabio Valentini 2022-08-17 21:48:34 UTC
Thanks, looks good to me now.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass (there are no tests)
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license for binary sub-package is correctly specified
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Nit-pick: Upstream might want to exclude the "sigtest.go" file from published crate sources, it seems like source code for an unused test binary.

Comment 8 Davide Cavalca 2022-08-18 18:16:42 UTC
Thanks!

$ fedpkg request-repo rust-sinit 1991149
https://pagure.io/releng/fedora-scm-requests/issue/46517
$ fedpkg request-branch --repo rust-sinit f37
https://pagure.io/releng/fedora-scm-requests/issue/46518
$ fedpkg request-branch --repo rust-sinit f36
https://pagure.io/releng/fedora-scm-requests/issue/46519
$ fedpkg request-branch --repo rust-sinit f35
https://pagure.io/releng/fedora-scm-requests/issue/46520

Comment 9 Gwyn Ciesla 2022-08-18 19:32:22 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sinit

Comment 10 Fedora Update System 2022-08-19 17:15:04 UTC
FEDORA-2022-a6b50670be has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a6b50670be

Comment 11 Fedora Update System 2022-08-19 17:26:15 UTC
FEDORA-2022-9717d7b577 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9717d7b577

Comment 12 Fedora Update System 2022-08-19 17:29:50 UTC
FEDORA-2022-a6b50670be has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2022-08-19 17:32:56 UTC
FEDORA-2022-9717d7b577 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2022-08-19 17:42:50 UTC
FEDORA-2022-c6605f7660 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-c6605f7660

Comment 15 Fedora Update System 2022-08-19 17:51:43 UTC
FEDORA-2022-e163f1739d has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-e163f1739d

Comment 16 Fedora Update System 2022-08-20 02:23:51 UTC
FEDORA-2022-c6605f7660 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-c6605f7660 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-c6605f7660

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2022-08-20 02:36:36 UTC
FEDORA-2022-e163f1739d has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-e163f1739d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-e163f1739d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Fedora Update System 2022-08-27 20:45:42 UTC
FEDORA-2022-c6605f7660 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2022-08-27 20:52:54 UTC
FEDORA-2022-e163f1739d has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.