Bug 1991696

Summary:	Review Request: rust-similar-asserts - Provides assert_eq! like macros with colorized diff output
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Davide Cavalca <davide>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	davide, package-review
Target Milestone:	---	Flags:	davide: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-08-26 19:17:58 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1991695
Bug Blocks:	1884296

Description Fabio Valentini 2021-08-09 18:03:46 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-similar-asserts.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-similar-asserts-1.1.0-1.fc34.src.rpm

Description:
Provides assert_eq! like macros with colorized diff output.

Fedora Account System Username: decathorpe

Comment 1 Davide Cavalca 2021-08-26 04:25:16 UTC

Taking this review

Comment 2 Davide Cavalca 2021-08-26 04:29:45 UTC

Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- License is correct and valid
- Only sources installed
- Latest version packaged
- Package builds fine in Rawhide
- Consider switching to rpmautospec on import to ease future maintenance

PACKAGE APPROVED.

Comment 3 Fabio Valentini 2021-08-26 09:37:08 UTC

Thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/36521
https://pagure.io/releng/fedora-scm-requests/issue/36522
https://pagure.io/releng/fedora-scm-requests/issue/36523

Comment 4 Tomas Hrcka 2021-08-26 11:41:40 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-similar-asserts

Comment 5 Fedora Update System 2021-08-26 19:17:58 UTC

FEDORA-2021-57a0d19aea has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.