Bug 1991696 - Review Request: rust-similar-asserts - Provides assert_eq! like macros with colorized diff output
Summary: Review Request: rust-similar-asserts - Provides assert_eq! like macros with c...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1991695
Blocks: 1884296
TreeView+ depends on / blocked
 
Reported: 2021-08-09 18:03 UTC by Fabio Valentini
Modified: 2021-08-26 19:17 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-08-26 19:17:58 UTC
Type: ---
Embargoed:
davide: fedora-review+

Attachments (Terms of Use)

Description Fabio Valentini 2021-08-09 18:03:46 UTC 
Spec URL: https://decathorpe.fedorapeople.org/rust-similar-asserts.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-similar-asserts-1.1.0-1.fc34.src.rpm

Description:
Provides assert_eq! like macros with colorized diff output.

Fedora Account System Username: decathorpe
Comment 1 Davide Cavalca 2021-08-26 04:25:16 UTC 
Taking this review
Comment 2 Davide Cavalca 2021-08-26 04:29:45 UTC 
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- License is correct and valid
- Only sources installed
- Latest version packaged
- Package builds fine in Rawhide
- Consider switching to rpmautospec on import to ease future maintenance

PACKAGE APPROVED.
Comment 3 Fabio Valentini 2021-08-26 09:37:08 UTC 
Thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/36521
https://pagure.io/releng/fedora-scm-requests/issue/36522
https://pagure.io/releng/fedora-scm-requests/issue/36523
Comment 4 Tomas Hrcka 2021-08-26 11:41:40 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-similar-asserts
Comment 5 Fedora Update System 2021-08-26 19:17:58 UTC 
FEDORA-2021-57a0d19aea has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.