Bug 1992627

Summary: Review Request: mozjs91 - JavaScript interpreter and libraries
Product: [Fedora] Fedora Reporter: František Zatloukal <fzatlouk>
Component: Package ReviewAssignee: Kalev Lember <klember>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: klember, package-review
Target Milestone: ---Flags: klember: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: mozjs91-91.0-1.fc36 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-08-24 15:13:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description František Zatloukal 2021-08-11 12:50:50 UTC 
SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/mozjs91/fedora-rawhide-x86_64/02504889-mozjs91/mozjs91.spec

SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/mozjs91/fedora-rawhide-x86_64/02504889-mozjs91/mozjs91-91.0-1.fc35.src.rpm

Scratch: https://koji.fedoraproject.org/koji/taskinfo?taskID=73669860


Package is based on mozjs78, it's installable parallelly, with rebased and cleaned up downstream patches.
Comment 1 Kalev Lember 2021-08-24 10:56:48 UTC 
Looks good to me. I don't think this actually needs a formal review since there's a review exception for parallel installable versions.

In any case, this looks good to me and follows packaging guidelines for parallel installable packages. I didn't do a full review here since it's essentially the same as existing mozjs78 and just a new, parallel installable version.

Just some nits I noticed:

> # Require libatomic for ppc
> %ifarch ppc
> %global system_libatomic 1
> %endif

I think all of system_libatomic conditionals can go since we don't build for ppc any more.

> export LINKFLAGS="%{?__global_ldflags}"
> export PYTHON="%{__python3}"

I believe (but not 100% sure) that the preferred versions to use these days are %{build_ldflags} and %{python3} (without leading underscores).

> %ldconfig_scriptlets

This can go as well: it expands to nothing on modern fedora.

Great work with this! Thanks for putting in all the work of keeping mozjs up to date and packaged.
Comment 2 Tomas Hrcka 2021-08-24 13:08:56 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/mozjs91
Comment 3 František Zatloukal 2021-08-24 15:13:23 UTC 
Landed in Rawhide and F35 (missed the freeze, will hit stable repos either with FE or after Beta release).