Fedora Account System
Red Hat Associate
Red Hat Customer
SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/mozjs91/fedora-rawhide-x86_64/02504889-mozjs91/mozjs91.spec SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/mozjs91/fedora-rawhide-x86_64/02504889-mozjs91/mozjs91-91.0-1.fc35.src.rpm Scratch: https://koji.fedoraproject.org/koji/taskinfo?taskID=73669860 Package is based on mozjs78, it's installable parallelly, with rebased and cleaned up downstream patches.
Looks good to me. I don't think this actually needs a formal review since there's a review exception for parallel installable versions. In any case, this looks good to me and follows packaging guidelines for parallel installable packages. I didn't do a full review here since it's essentially the same as existing mozjs78 and just a new, parallel installable version. Just some nits I noticed: > # Require libatomic for ppc > %ifarch ppc > %global system_libatomic 1 > %endif I think all of system_libatomic conditionals can go since we don't build for ppc any more. > export LINKFLAGS="%{?__global_ldflags}" > export PYTHON="%{__python3}" I believe (but not 100% sure) that the preferred versions to use these days are %{build_ldflags} and %{python3} (without leading underscores). > %ldconfig_scriptlets This can go as well: it expands to nothing on modern fedora. Great work with this! Thanks for putting in all the work of keeping mozjs up to date and packaged.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mozjs91
Landed in Rawhide and F35 (missed the freeze, will hit stable repos either with FE or after Beta release).