Bug 1992668
| Summary: | [RFE] Provide add/remove syntax for command `pcs stonith update-scsi-devices` | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Miroslav Lisik <mlisik> | ||||
| Component: | pcs | Assignee: | Miroslav Lisik <mlisik> | ||||
| Status: | CLOSED ERRATA | QA Contact: | cluster-qe <cluster-qe> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 8.5 | CC: | cfeist, cluster-maint, idevat, kmalyjur, lmiksik, mlisik, mmazoure, mpospisi, nhostako, omular, sbradley, slevine, tojeline | ||||
| Target Milestone: | beta | Keywords: | FutureFeature, Triaged | ||||
| Target Release: | 8.5 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | pcs-0.10.10-3.el8 | Doc Type: | Enhancement | ||||
| Doc Text: |
Feature:
Provide add/remove syntax for command `pcs stonith update-scsi-devices`
Reason:
The add/remove syntax of the command is more comfortable for a user because it does not need to specify currently configured devices.
Result:
Command `pcs stonith update-scsi-devices` now supports add/remove syntax for updating fence scsi devices.
|
Story Points: | --- | ||||
| Clone Of: | |||||||
| : | 2003068 (view as bug list) | Environment: | |||||
| Last Closed: | 2021-11-09 17:34:53 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2003068 | ||||||
| Attachments: |
|
||||||
|
Description
Miroslav Lisik
2021-08-11 14:07:52 UTC
Created attachment 1822045 [details]
proposed fix + tests
Updated command:
* pcs stonith update-scsi-devices
Test:
* setup a cluster with a fence scsi stonith resource
* setup resources running on each node
* update fence scsi devices using command `pcs stonith update-scsi-devices add <device>... remove <device>...
* check that resources were not restarted after update of devices
DevTestResults: [root@r8-node-01 ~]# rpm -q pcs pcs-0.10.10-3.el8.x86_64 export disk1=/dev/disk/by-id/scsi-360014052bc36324cf7d4a709a959340b export disk2=/dev/disk/by-id/scsi-3600140547721f8ee2774aa8bac6d8ebe [root@r8-node-01 ~]# pcs stonith * fence-scsi (stonith:fence_scsi): Started r8-node-01 [root@r8-node-01 ~]# pcs stonith config Resource: fence-scsi (class=stonith type=fence_scsi) Attributes: devices=/dev/disk/by-id/scsi-360014052bc36324cf7d4a709a959340b pcmk_host_check=static-list pcmk_host_list="r8-node-01 r8-node-02 r8-node-03" pcmk_reboot_action=off Meta Attrs: provides=unfencing Operations: monitor interval=60s (fence-scsi-monitor-interval-60s) [root@r8-node-01 ~]# pcs resource * d-01 (ocf::pacemaker:Dummy): Started r8-node-02 * d-02 (ocf::pacemaker:Dummy): Started r8-node-03 * d-03 (ocf::pacemaker:Dummy): Started r8-node-01 * d-04 (ocf::pacemaker:Dummy): Started r8-node-02 * d-05 (ocf::pacemaker:Dummy): Started r8-node-03 * d-06 (ocf::pacemaker:Dummy): Started r8-node-01 [root@r8-node-01 ~]# sg_persist -n -i -k -d $disk2 PR generation=0x6, there are NO registered reservation keys [root@r8-node-01 ~]# pcs stonith update-scsi-devices fence-scsi add $disk2 remove $disk1 [root@r8-node-01 ~]# echo $? 0 [root@r8-node-01 ~]# pcs stonith config Resource: fence-scsi (class=stonith type=fence_scsi) Attributes: devices=/dev/disk/by-id/scsi-3600140547721f8ee2774aa8bac6d8ebe pcmk_host_check=static-list pcmk_host_list="r8-node-01 r8-node-02 r8-node-03" pcmk_reboot_action=off Meta Attrs: provides=unfencing Operations: monitor interval=60s (fence-scsi-monitor-interval-60s) Scsi devices have been updated. [root@r8-node-01 ~]# tail -f /var/log/messages -n 0 Sep 10 12:20:13 r8-node-01 kernel: sda: sda1 Sep 10 12:20:13 r8-node-01 kernel: sda: sda1 Sep 10 12:20:13 r8-node-01 kernel: sd 6:0:0:0: reservation conflict Sep 10 12:20:13 r8-node-01 pacemaker-controld[427444]: notice: State transition S_IDLE -> S_POLICY_ENGINE Sep 10 12:20:13 r8-node-01 pacemaker-fenced[427440]: notice: Added 'fence-scsi' to device list (1 active device) Sep 10 12:20:13 r8-node-01 pacemaker-schedulerd[427443]: notice: Calculated transition 9, saving inputs in /var/lib/pacemaker/pengine/pe-input-360.bz2 Sep 10 12:20:13 r8-node-01 pacemaker-controld[427444]: notice: Transition 9 (Complete=0, Pending=0, Fired=0, Skipped=0, Incomplete=0, Source=/var/lib/pacemaker/pengine/pe-input-360.bz2): Complete Sep 10 12:20:13 r8-node-01 pacemaker-controld[427444]: notice: State transition S_TRANSITION_ENGINE -> S_IDLE [root@r8-node-02 ~]# tail -f /var/log/messages -n 0 Sep 10 12:20:13 r8-node-02 kernel: sd 6:0:0:0: Parameters changed Sep 10 12:20:13 r8-node-02 kernel: sda: sda1 Sep 10 12:20:13 r8-node-02 kernel: sda: sda1 Sep 10 12:20:13 r8-node-02 pacemaker-fenced[335575]: notice: Added 'fence-scsi' to device list (1 active device) [root@r8-node-03 ~]# tail -f /var/log/messages -n 0 Sep 10 12:20:13 r8-node-03 kernel: sd 6:0:0:0: Parameters changed Sep 10 12:20:13 r8-node-03 kernel: sda: sda1 Sep 10 12:20:13 r8-node-03 kernel: sda: sda1 Sep 10 12:20:13 r8-node-03 pacemaker-fenced[335926]: notice: Added 'fence-scsi' to device list (1 active device) No resources were restarted. re-setting fixed in version to pcs-0.10.10-3.el8 nothing changed in this bz. I wrongly copied bz number to the commit message. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Low: pcs security, bug fix, and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2021:4142 |