Bug 1993634

Taking this review.

I have added JT as a packager in bug 1993632, so he no longer requires sponsorship.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU General Public License v2.0 or
     later". 40 files have unknown license. Detailed output of licensecheck
     in /home/ngompa/1993634-fedora-jam-kde-theme/licensecheck.txt
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /etc/skel/.config/gtk-3.0, /etc/skel/.config
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/plasma/look-and-
     feel, /etc/sysctl.d, /usr/share/sddm/themes,
     /etc/skel/.config/gtk-3.0, /usr/share/sddm, /etc/skel/.config
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: %config files are marked noreplace or the reason is justified.
     Note: No (noreplace) in %config /etc/skel/.gtkrc-2.0 %config
     /etc/skel/.config/gtk-3.0/settings.ini
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: fedora-jam-kde-theme-3.0.6-2.fc34.noarch.rpm
          fedora-jam-kde-theme-3.0.6-2.fc34.src.rpm
fedora-jam-kde-theme.noarch: W: conffile-without-noreplace-flag /etc/skel/.config/gtk-3.0/settings.ini
fedora-jam-kde-theme.noarch: W: conffile-without-noreplace-flag /etc/skel/.gtkrc-2.0
fedora-jam-kde-theme.noarch: W: no-documentation
fedora-jam-kde-theme.noarch: W: non-conffile-in-etc /etc/xdg/plasma-workspace/env/env-jam.sh
fedora-jam-kde-theme.noarch: W: hidden-file-or-dir /usr/share/kde-jam-settings/kde-profile/default/.kdeprofile
fedora-jam-kde-theme.noarch: E: zero-length /usr/share/kde-jam-settings/kde-profile/default/share/services/update_ksycoca
fedora-jam-kde-theme.noarch: E: zero-length /usr/share/plasma/look-and-feel/org.fedoraproject.fedora-jam.desktop/contents/previews/desktopswitcher.png
fedora-jam-kde-theme.noarch: E: zero-length /usr/share/plasma/look-and-feel/org.fedoraproject.fedora-jam.desktop/contents/previews/loginmanager.png
fedora-jam-kde-theme.noarch: E: zero-length /usr/share/plasma/look-and-feel/org.fedoraproject.fedora-jam.desktop/contents/previews/runcommand.png
fedora-jam-kde-theme.noarch: E: zero-length /usr/share/plasma/look-and-feel/org.fedoraproject.fedora-jam.desktop/contents/previews/userswitcher.png
fedora-jam-kde-theme.noarch: E: zero-length /usr/share/plasma/look-and-feel/org.fedoraproject.fedora-jam.desktop/contents/previews/windowdecoration.png
fedora-jam-kde-theme.noarch: E: zero-length /usr/share/plasma/look-and-feel/org.fedoraproject.fedora-jam.desktop/contents/previews/windowswitcher.png
fedora-jam-kde-theme.noarch: W: dangling-relative-symlink /usr/share/sddm/themes/00-breeze-fedora-jam/Background.qml ../breeze/Background.qml
fedora-jam-kde-theme.noarch: W: dangling-relative-symlink /usr/share/sddm/themes/00-breeze-fedora-jam/BreezeMenuStyle.qml ../breeze/BreezeMenuStyle.qml
fedora-jam-kde-theme.noarch: W: dangling-relative-symlink /usr/share/sddm/themes/00-breeze-fedora-jam/KeyboardButton.qml ../breeze/KeyboardButton.qml
fedora-jam-kde-theme.noarch: W: dangling-relative-symlink /usr/share/sddm/themes/00-breeze-fedora-jam/Login.qml ../breeze/Login.qml
fedora-jam-kde-theme.noarch: W: dangling-relative-symlink /usr/share/sddm/themes/00-breeze-fedora-jam/Main.qml ../breeze/Main.qml
fedora-jam-kde-theme.noarch: W: dangling-relative-symlink /usr/share/sddm/themes/00-breeze-fedora-jam/SessionButton.qml ../breeze/SessionButton.qml
fedora-jam-kde-theme.noarch: W: dangling-relative-symlink /usr/share/sddm/themes/00-breeze-fedora-jam/components ../breeze/components
fedora-jam-kde-theme.noarch: W: dangling-relative-symlink /usr/share/sddm/themes/00-breeze-fedora-jam/faces ../breeze/faces
2 packages and 0 specfiles checked; 7 errors, 13 warnings.




Rpmlint (installed packages)
----------------------------
fedora-jam-kde-theme.noarch: W: conffile-without-noreplace-flag /etc/skel/.config/gtk-3.0/settings.ini
fedora-jam-kde-theme.noarch: W: conffile-without-noreplace-flag /etc/skel/.gtkrc-2.0
fedora-jam-kde-theme.noarch: W: no-documentation
fedora-jam-kde-theme.noarch: W: non-conffile-in-etc /etc/xdg/plasma-workspace/env/env-jam.sh
fedora-jam-kde-theme.noarch: W: hidden-file-or-dir /usr/share/kde-jam-settings/kde-profile/default/.kdeprofile
fedora-jam-kde-theme.noarch: E: zero-length /usr/share/kde-jam-settings/kde-profile/default/share/services/update_ksycoca
fedora-jam-kde-theme.noarch: E: zero-length /usr/share/plasma/look-and-feel/org.fedoraproject.fedora-jam.desktop/contents/previews/desktopswitcher.png
fedora-jam-kde-theme.noarch: E: zero-length /usr/share/plasma/look-and-feel/org.fedoraproject.fedora-jam.desktop/contents/previews/loginmanager.png
fedora-jam-kde-theme.noarch: E: zero-length /usr/share/plasma/look-and-feel/org.fedoraproject.fedora-jam.desktop/contents/previews/runcommand.png
fedora-jam-kde-theme.noarch: E: zero-length /usr/share/plasma/look-and-feel/org.fedoraproject.fedora-jam.desktop/contents/previews/userswitcher.png
fedora-jam-kde-theme.noarch: E: zero-length /usr/share/plasma/look-and-feel/org.fedoraproject.fedora-jam.desktop/contents/previews/windowdecoration.png
fedora-jam-kde-theme.noarch: E: zero-length /usr/share/plasma/look-and-feel/org.fedoraproject.fedora-jam.desktop/contents/previews/windowswitcher.png
fedora-jam-kde-theme.noarch: W: dangling-relative-symlink /usr/share/sddm/themes/00-breeze-fedora-jam/Background.qml ../breeze/Background.qml
fedora-jam-kde-theme.noarch: W: dangling-relative-symlink /usr/share/sddm/themes/00-breeze-fedora-jam/BreezeMenuStyle.qml ../breeze/BreezeMenuStyle.qml
fedora-jam-kde-theme.noarch: W: dangling-relative-symlink /usr/share/sddm/themes/00-breeze-fedora-jam/KeyboardButton.qml ../breeze/KeyboardButton.qml
fedora-jam-kde-theme.noarch: W: dangling-relative-symlink /usr/share/sddm/themes/00-breeze-fedora-jam/Login.qml ../breeze/Login.qml
fedora-jam-kde-theme.noarch: W: dangling-relative-symlink /usr/share/sddm/themes/00-breeze-fedora-jam/Main.qml ../breeze/Main.qml
fedora-jam-kde-theme.noarch: W: dangling-relative-symlink /usr/share/sddm/themes/00-breeze-fedora-jam/SessionButton.qml ../breeze/SessionButton.qml
fedora-jam-kde-theme.noarch: W: dangling-relative-symlink /usr/share/sddm/themes/00-breeze-fedora-jam/components ../breeze/components
fedora-jam-kde-theme.noarch: W: dangling-relative-symlink /usr/share/sddm/themes/00-breeze-fedora-jam/faces ../breeze/faces
1 packages and 0 specfiles checked; 7 errors, 13 warnings.



Source checksums
----------------
https://pagure.io/fedora-jam-kde-theme/archive/3.0.6/fedora-jam-kde-theme-3.0.6.tar.gz :
  CHECKSUM(SHA256) this package     : 9f65e80f1905606a0f278d875dadd9282785cf23e96dcc8110e5adc803fac0ee
  CHECKSUM(SHA256) upstream package : 9f65e80f1905606a0f278d875dadd9282785cf23e96dcc8110e5adc803fac0ee


Requires
--------
fedora-jam-kde-theme (rpmlib, GLIBC filtered):
    breeze-gtk
    breeze-icon-theme
    config(fedora-jam-kde-theme)
    fedora-jam-backgrounds-kde
    kde-filesystem
    kde-settings
    kde-settings-plasma
    xdg-user-dirs



Provides
--------
fedora-jam-kde-theme:
    config(fedora-jam-kde-theme)
    fedora-jam-kde-theme



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1993634 -m fedora-34-x86_64
Buildroot used: fedora-34-x86_64
Active plugins: Shell-api, Generic
Disabled plugins: Python, Haskell, PHP, C/C++, fonts, Ocaml, Java, R, SugarActivity, Perl
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

There's no serious issues with the package, so...

PACKAGE APPROVED.

Package is now in repositories, closing review.