Spec URL: https://download.copr.fedorainfracloud.org/results/q5sys/Fedora-Jam/fedora-34-x86_64/02521130-fedora-jam-backgrounds/fedora-jam-backgrounds.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/q5sys/Fedora-Jam/fedora-34-x86_64/02521130-fedora-jam-backgrounds/fedora-jam-backgrounds-2.0.0-3.fc34.src.rpm Description: Package of backgrounds for the Fedora Jam Lab, this package is a dependency of the lab. Fedora Account System Username: q5sys
Taking this review.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Creative Commons CC0 Universal 1.0 Public Domain Dedication". 10 files have unknown license. Detailed output of licensecheck in /home/ngompa/1993632-fedora-jam-backgrounds/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/xfce4, /usr/share/gnome-background-properties, /usr/share/xfce4/backdrops [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in fedora- jam-backgrounds-single , fedora-jam-backgrounds-kde , fedora-jam- backgrounds-gnome , fedora-jam-backgrounds-xfce [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: fedora-jam-backgrounds-2.0.0-3.fc34.noarch.rpm fedora-jam-backgrounds-single-2.0.0-3.fc34.noarch.rpm fedora-jam-backgrounds-kde-2.0.0-3.fc34.noarch.rpm fedora-jam-backgrounds-gnome-2.0.0-3.fc34.noarch.rpm fedora-jam-backgrounds-xfce-2.0.0-3.fc34.noarch.rpm fedora-jam-backgrounds-2.0.0-3.fc34.src.rpm fedora-jam-backgrounds.noarch: W: no-documentation fedora-jam-backgrounds-kde.noarch: W: no-documentation fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1024x600.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1024x768.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1152x720.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1152x864.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1200x900.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1280x1024.png ../../../../backgrounds/fedora-jam/default/normalish/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1280x720.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1280x768.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1280x800.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1280x960.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1366x768.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1440x1080.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1440x900.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1600x1200.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1600x1280.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1680x1050.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1920x1080.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1920x1200.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1920x1440.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/2048x1536.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/640x480.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/800x480.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/800x600.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-gnome.noarch: W: no-documentation fedora-jam-backgrounds-xfce.noarch: W: no-documentation fedora-jam-backgrounds-xfce.noarch: W: dangling-relative-symlink /usr/share/xfce4/backdrops/fedora-jam.png ../../backgrounds/fedora-jam/default/wide/fedora-jam.png 6 packages and 0 specfiles checked; 0 errors, 28 warnings. Rpmlint (installed packages) ---------------------------- fedora-jam-backgrounds.noarch: W: no-documentation fedora-jam-backgrounds-kde.noarch: W: no-documentation fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1024x600.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1024x768.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1152x720.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1152x864.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1200x900.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1280x1024.png ../../../../backgrounds/fedora-jam/default/normalish/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1280x720.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1280x768.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1280x800.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1280x960.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1366x768.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1440x1080.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1440x900.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1600x1200.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1600x1280.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1680x1050.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1920x1080.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1920x1200.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/1920x1440.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/2048x1536.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/640x480.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/800x480.png ../../../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Fedora_Jam/contents/images/800x600.png ../../../../backgrounds/fedora-jam/default/standard/fedora-jam.png fedora-jam-backgrounds-xfce.noarch: W: no-documentation fedora-jam-backgrounds-xfce.noarch: W: dangling-relative-symlink /usr/share/xfce4/backdrops/fedora-jam.png ../../backgrounds/fedora-jam/default/wide/fedora-jam.png fedora-jam-backgrounds-gnome.noarch: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 28 warnings. Source checksums ---------------- https://pagure.io/fedora-jam-backgrounds/archive/2.0.0/fedora-jam-backgrounds-2.0.0.tar.gz : CHECKSUM(SHA256) this package : b7ac9de1fc4f1869bc0d9d23ef45c8c33cb5927037581b1fde92486f41050d9f CHECKSUM(SHA256) upstream package : b7ac9de1fc4f1869bc0d9d23ef45c8c33cb5927037581b1fde92486f41050d9f Requires -------- fedora-jam-backgrounds (rpmlib, GLIBC filtered): fedora-jam-backgrounds-gnome fedora-jam-backgrounds-kde fedora-jam-backgrounds-single (rpmlib, GLIBC filtered): fedora-jam-backgrounds-kde (rpmlib, GLIBC filtered): fedora-jam-backgrounds-single kde-filesystem fedora-jam-backgrounds-gnome (rpmlib, GLIBC filtered): fedora-jam-backgrounds-single fedora-jam-backgrounds-xfce (rpmlib, GLIBC filtered): fedora-jam-backgrounds-single xfdesktop Provides -------- fedora-jam-backgrounds: fedora-jam-backgrounds fedora-jam-backgrounds-single: fedora-jam-backgrounds-single fedora-jam-backgrounds-kde: fedora-jam-backgrounds-kde fedora-jam-backgrounds-gnome: fedora-jam-backgrounds-gnome fedora-jam-backgrounds-xfce: fedora-jam-backgrounds-xfce Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1993632 -m fedora-34-x86_64 Buildroot used: fedora-34-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Perl, fonts, PHP, Java, SugarActivity, C/C++, Ocaml, R, Haskell, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
There's no serious issues with the package, so... PACKAGE APPROVED.
I have also sponsored JT as a packager. Welcome to the Fedora Packagers group, and good luck with Fedora Jam! :)
Package is now in repositories, closing review.