Bug 199381
Summary: | PATCH: sparc sun drivers | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Dennis Gilmore <dennis> | ||||||
Component: | xorg-x11-drivers | Assignee: | Adam Jackson <ajax> | ||||||
Status: | CLOSED RAWHIDE | QA Contact: | |||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | medium | ||||||||
Version: | rawhide | Keywords: | EasyFix | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | sparc | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2007-07-27 21:56:32 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Dennis Gilmore
2006-07-19 04:03:37 UTC
Created attachment 132658 [details]
sun drivers
The Requires in this package are automatically generated by a one liner shell script present in a comment in the spec file, as that is the only sane way to ensure the package is in sync with what the actual driver packages are in the OS. When someone changes a driver, they are likely to forget to update the drivers package, or to introduce inconsistencies, so having it scriptable is a big advantage. However, this approach unintentionally imposes a limit on which architectures the package handles. The solution I've got in mind for this is to change the script from listing one ifarch block per driver, to having one ifarch block per arch, and having a number of Requires: lines in the single block for the given driver. That will serve 3 useful purposes: - Allows us to autogenerate the architectures we build for. - Allows us to include statically generated content in the spec for 3rd party architectures such as sparc to supplement the autogenerated bits. - Will make the spec file much smaller and neater looking. Just need to write the script code that will spit out output of the form: %ifarch %{ix86} Requires: xorg-x11-drv-ati xorg-x11-drv-i810 ... Requires: xorg.... %endif %ifarch x86_64 Requires: ... %endif ..., with each Requires line having a maximum of 4 drivers listed per line for readability. I suspect a small perl script is the quickest and easiest way to do this. Low priority right now, but I'll implement it at some point. In the mean time, I can add a hack into the spec for sparc for now. Can you rewrite the spec in the form: %ifarch sparc sparc64 Requires: <all of the new drivers to add> %endif Also, you generated your patch backwards (args reversed). TIA Created attachment 136038 [details]
adds sparc drivers as requested
With secondary archs to come online soon. I will be submitting all the sun drivers for review and then they will live in fedora cvs space. maybe that will help Dennis, I've added you to the acl for xorg-x11-drivers. When you've got the sun drivers in CVS, go ahead and add them to the drivers metapackage behind %ifarch. |