Bug 199389

Hmm, those settings are user configurable in scim-setup,
but I suppose it might be useful to have the trigger hotkey at least appear
at the top of the help dialog.  BTW the Ctrl+Shift (next/previous factory
hotkeys are only defined by default for Chinese users for fc6).

scim-anthy doesn't provide any information about general scim hotkeys,
only anthy specific bindings.

I agree with Jens and put this bug to wontfix.
(In reply to comment #1)
> Hmm, those settings are user configurable in scim-setup,
> but I suppose it might be useful to have the trigger hotkey at least appear
> at the top of the help dialog.  BTW the Ctrl+Shift (next/previous factory
> hotkeys are only defined by default for Chinese users for fc6).
> 
> scim-anthy doesn't provide any information about general scim hotkeys,
> only anthy specific bindings.

Well I think it would be good display some of the global hotkeys in the help.
It shouldn't be too hard to add.

What's kind of global hotkeys? 
The hotkeys can be changed by user self. I think global hotkeys should not be
displayed in Engines help. Engine help should only contain hotkeys in Engine,
not global.

Yep it should not be hardcoded, scim should display the current hotkey bindings
at the top of the help text IMHO.

One action may has null hotkey, one hotkey or many hotkeys. How about just show
the fist hotkey for one action?

Created attachment 297144 [details]
patch

Created attachment 297145 [details]
patch

Created attachment 297146 [details]
updated spec

Found the help string is from scim-bridge. 
It has been fixed in scim-bridge-0.4.15-2.
Thanks Caius Chance.

I don't really understand why the help comes from scim-bridge:
really it should not depend on what immodule or XIM is used
since the hotkeys are global and (should be) independent of
the immodule.  So this looks like a design issue in SCIM.

Currently it seems we will get different help from im-scim, scim-bridge,
and scim-qtimm (maybe im-scim and XIM are the same?).

How's upstream thinking?

(In reply to comment #11)
> I don't really understand why the help comes from scim-bridge:
> really it should not depend on what immodule or XIM is used
> since the hotkeys are global and (should be) independent of
> the immodule.  So this looks like a design issue in SCIM.
> 
> Currently it seems we will get different help from im-scim, scim-bridge,
> and scim-qtimm (maybe im-scim and XIM are the same?).

I found the help string is not from im module. It is from scim-bridge-agent when
using scim-bridge. When just using scim, the help string is from scim-panel-gtk.

> I found the help string is not from im module. It is from scim-bridge-agent when
> using scim-bridge. When just using scim, the help string is from scim-panel-gtk.

Ok, I see thanks.

Currently I now see:

"""
Smart Common Input Method platform 1.4.6      <--  note wrong version!! (should
be scim-bridge version I guess or something like that)
(C) 2002-2005 James Su <suzhe.cn>    <-- the date is out of date too

Global Hotkeys:
                         <-- better not to have a newline IMHO to save space
Trigger: Zenkaku_Hankaku,Alt+grave,Control+space   <-- probably most users don't
know what "trigger" means
                         <-- better no newline again
Turn on: Unable to be loaded.              <-- this should say "undefined"
                         <-- again can drop empty line
Turn off: Unable to be loaded.             <-- should be changed
                         <-- no newline
Next input method:

Previous input method:

<IME help.....>
"""

I think it is better not to mention undefined/empty hotkeys anyway
(trigger is the most important one anyway).

Also it would be better to remove the "Smart Common Input Method"
frame around the help text widget - it looks strange.

> Also it would be better to remove the "Smart Common Input Method"
> frame around the help text widget - it looks strange.

Doing that in scim-1.4.7-17.fc9.

Created attachment 303112 [details]
patch

Excessive newlines are removed.

Undefined hot keys will not be shown.

Created attachment 303115 [details]
update patch with gettext macro'ed

Created attachment 303116 [details]
spec

Hi cchance,
I found two little problems. One is that you modified the header of help text. I
think you should not do it. The helper text is for scim, not for scim-bridge. So
I you should remain the origin header.
The another is the spec file is not based on the newest version spec file in cvs.

(In reply to comment #19)
> I found two little problems. One is that you modified the header of help text. I
> think you should not do it. The helper text is for scim, not for scim-bridge. So
> I you should remain the origin header.

This is based on the patch suggested my jensp. I'll ask him about this.

> The another is the spec file is not based on the newest version spec file in cvs.
> 

You could ignore the spec attachment if so. The only change is addition of the
patch, release number, and changelog.

Created attachment 303231 [details]
spec patch

(No need to rename the patch BTW, we can just update the current patch.)

(In reply to comment #19)
> One is that you modified the header of help text. I
> think you should not do it. The helper text is for scim, not for scim-bridge. So
> I you should remain the origin header.

Ok lets include both copyright for scim and scim-bridge, but not mention the
scim version in the text.  I think it is good to show which immodule is being
used too.

Also as I suggested to Caius, I still feel the patch should be possible just
on scim-bridge-agent-imcontext.cpp, I am still unclear why it has to be
split over scim-bridge-agent.cpp.

Created attachment 309559 [details]
Removed patch rename, version and changelog correction only.

(In reply to comment #22)
> Also as I suggested to Caius, I still feel the patch should be possible just
> on scim-bridge-agent-imcontext.cpp, I am still unclear why it has to be
> split over scim-bridge-agent.cpp.

To display the hotkeys used in helper, we need info from config. However,
scim-bridge-agent-imcontext.cpp which is responsible to display helper doesn't
have any code currently accessing data in config.

Using scim-bridge-agent.cpp to 'feed' hotkey info to
scim-bridge-agent-imcontext.cpp is the most efficient way to achieve the
objective. Otherwise, we need to duplicate large amount of config info
preparation code in scim-bridge-agent-imcontext.cpp just to have maximum of 5
used hotkeys.

The extra work doesn't include extra code analysis, testing and higher potential
impact to the quality, too.

Created attachment 310009 [details]
Cleaned up patch.

Hotkey settings are listed single newlines.
Author info, version, dates are fixed.
Removed unnecessary indentation changes in patch file.

scim-tables-0.5.8-3.fc9 has been submitted as an update for Fedora 9

scim-tables-0.5.8-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 26 and comment 27 refer to bug 438662