Bug 1994063
| Summary: | Review Request: nginx-mod-naxsi - nginx web application firewall module | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Neal Gompa <ngompa13> |
| Component: | Package Review | Assignee: | Davide Cavalca <davide> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | davide, daxelrod, fedora, package-review |
| Target Milestone: | --- | Flags: | davide:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-08-26 21:07:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Neal Gompa
2021-08-16 15:56:47 UTC
- build fails due to missing nginx-mod-devel - use install -p to preserve timestamps Ok looks like I can get this further in mock with --enablerepo local, but the build fails at the end with:
Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.orW5vF
+ umask 022
+ cd /builddir/build/BUILD
+ '[' /builddir/build/BUILDROOT/nginx-mod-naxsi-1.3-1.fc36.x86_64 '!=' / ']'
+ rm -rf /builddir/build/BUILDROOT/nginx-mod-naxsi-1.3-1.fc36.x86_64
++ dirname /builddir/build/BUILDROOT/nginx-mod-naxsi-1.3-1.fc36.x86_64
+ mkdir -p /builddir/build/BUILDROOT
+ mkdir /builddir/build/BUILDROOT/nginx-mod-naxsi-1.3-1.fc36.x86_64
+ cd naxsi-1.3
~/build/BUILD/naxsi-1.3/naxsi_src/redhat-linux-build ~/build/BUILD/naxsi-1.3
+ pushd naxsi_src/redhat-linux-build
+ install -dm 0755 /builddir/build/BUILDROOT/nginx-mod-naxsi-1.3-1.fc36.x86_64/usr/lib64/nginx/modules
+ install -m0755 ngx_http_naxsi_module.so /builddir/build/BUILDROOT/nginx-mod-naxsi-1.3-1.fc36.x86_64/usr/lib64/nginx/modules
+ popd
~/build/BUILD/naxsi-1.3
+ install -dm 0755 /builddir/build/BUILDROOT/nginx-mod-naxsi-1.3-1.fc36.x86_64/usr/share/nginx/modules
+ echo 'load_module "/usr/lib64/nginx/modules/ngx_http_naxsi_module.so";'
+ popd
/var/tmp/rpm-tmp.orW5vF: line 45: popd: directory stack empty
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.orW5vF (%install)
Bad exit status from /var/tmp/rpm-tmp.orW5vF (%install)
Looks like I goofed when I cleaned up the pushd/popd stuff. I've fixed that and updated the packages linked in the initial comment. You're still missing an install -p for the .so. Beyond that: - Packaging follows naming guidelines - Package licensing is indicated correctly - Packaging builds and installs (when dependencies are installed and pre-populated in the chroot) - No serious issues from rpmlint PACKAGE APPROVED. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nginx-mod-naxsi FEDORA-2021-9ba7f42344 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-9ba7f42344 FEDORA-2021-363146d5cc has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-363146d5cc FEDORA-2021-363146d5cc has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-363146d5cc \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-363146d5cc See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-9ba7f42344 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-9ba7f42344 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-9ba7f42344 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-363146d5cc has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2021-9ba7f42344 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. |